Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 20 Jun 2019 17:27:31 +0200
From:   Dominick Grift <dac.override@gmail.com>
To:     Alexander Miroshnichenko <alex@millerson.name>
Cc:     selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH v2 2/2] ssh: Add interface ssh_search_dir
Message-ID: <20190620152731.GD2647@brutus.lan>
Mail-Followup-To: Alexander Miroshnichenko <alex@millerson.name>,
        selinux-refpolicy@vger.kernel.org
References: <20190620144138.15172-1-alex@millerson.name>
 <20190620144138.15172-3-alex@millerson.name>
 <20190620145011.GC2647@brutus.lan>
 <642ea6d9-97c9-4ec4-a7ed-84995a953b48@millerson.name>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="/unnNtmY43mpUSKx"
Content-Disposition: inline
In-Reply-To: <642ea6d9-97c9-4ec4-a7ed-84995a953b48@millerson.name>
User-Agent: Every email client sucks, this one just sucks less.
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk


--/unnNtmY43mpUSKx
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jun 20, 2019 at 06:05:57PM +0300, Alexander Miroshnichenko wrote:
> On =D1=87=D0=B5=D1=82=D0=B2=D0=B5=D1=80=D0=B3, 20 =D0=B8=D1=8E=D0=BD=D1=
=8F 2019 =D0=B3. 17:50:11 MSK, Dominick Grift wrote:
> > On Thu, Jun 20, 2019 at 05:41:38PM +0300, Alexander Miroshnichenko wrot=
e:
> > > Create interface ssh_search_dir to allow ssh_server search for keys
> > > in non-standard location.
> > >=20
> > > Signed-off-by: Alexander Miroshnichenko <alex@millerson.name>
> > > ---
> > >  policy/modules/services/ssh.if | 18 ++++++++++++++++++
> > >  1 file changed, 18 insertions(+)
> > >=20
> > > diff --git a/policy/modules/services/ssh.if
> > > b/policy/modules/services/ssh.if
> > > index 0941f133711e..51c64ded00c4 100644
> > > --- a/policy/modules/services/ssh.if
> > > +++ b/policy/modules/services/ssh.if
> > > @@ -680,6 +680,24 @@ interface(`ssh_agent_exec',`
> > >  	can_exec($1, ssh_agent_exec_t)
> > >  ')
> > > +########################################
> > > +## <summary>
> > > +##      Search for keys in non-standard location
> > > +## </summary>
> > > +## <param name=3D"domain">
> > > +##      <summary>
> > > +##      Domain allowed access.
> > > +##      </summary>
> > > +## </param>
> > > +#
> > > +interface(`ssh_search_dir',`
> > > +        gen_require(`
> > > +                type sshd_t;
> > > +        ')
> > > +
> > > +	allow sshd_t $1:dir search_dir_perms;
> >=20
> > This is generally not allowed. The caller should generally be the sourc=
e.
> > Regardless of the above. Keys should be in user home directories. I
> > wonder what specific scenario prompted you to propose this interface?
>=20
> GIT hosting software like gitolite/gitosis/gitea manage users ssh keys and
> store them own location like /var/lib/gitolite/.ssh . /var/lib/gitolite h=
ave
> gitosis_var_lib_t type, /var/lib/gitolite/.ssh have gitosis_ssh_home_t ty=
pe
> (in patched policy which I want to submit).
> If sshd does not have { search getattr } permissions to full path to ssh =
key
> user fail to login.
> Can you propose corret way to give such permissions to multiple policies?
> It is incorrect to label /var/lib/gitolite as user_home_dir_t type, IMHO.

Yes this sucks. I would probably do the following instead:

1. echo "ignoredirs=3D/var/lib/gitolite" >> /etc/selinux/semanage.conf
2. semodule -B && restorecon -RvF /var/lib/gitolite
3. gitosis_read_lib_files(sshd_t)

Dont bother with labeling /var/lib/gitolite/.ssh differently

>=20
> > > +')
> > > +
> > >  ########################################
> > >  ## <summary>
> > >  ##	Read ssh home directory content ...
> >=20
>=20

--=20
Key fingerprint =3D 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02
https://sks-keyservers.net/pks/lookup?op=3Dget&search=3D0x3B6C5F1D2C7B6B02
Dominick Grift

--/unnNtmY43mpUSKx
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCAAdFiEEujmXliIBLFTc2Y4AJXSOVTf5R2kFAl0Lpd8ACgkQJXSOVTf5
R2lyfwv/XK4RGNoBgmZSJkLJoaNcVtviVjZjH+DEMUzJaHBLkC4yinW5bpEFOXI+
9n0sG89qKGrVj2jvB1qCYU9v02zCrWFnUHwISP4qzcLfGNYxR8/OrmM9LuTeN4fQ
PD0PU+CyCjp+p+WTMaDS1ASS5oe9WdTU9nwvIEHSNnjWYj9Tjx38EdhKoyayZXNf
d1FziYMRZUBsCInhhqNJsW65hyeZkNbKoUe4OLF5kGkuvRqXjWYP4B7VrW+uCXaS
DifeIX+J2jrb7SLjt3+YdgRMoUjOrlxCZ37DgyfeXwyRHQhQzbYDrI5FYzdAI5lF
9RnCtzpMvLfawcNZm0AjKJE0hC+nt6NJc/UMvlP6vAURShvY8GNbAjhONfauoVcA
2vNcpXcX41yI7T3Blw/mKpQya5m4pq/NlgAxealuyRogIZh9bn6e6rjypBcifuuF
ylddD8Fxr4HzYLa77soxJudFI/xB24dBfW9p/A2z73n1L49NK8+pviLQun5fvnC0
8qxA4YmY
=qbJn
-----END PGP SIGNATURE-----

--/unnNtmY43mpUSKx--