Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Alexander Miroshnichenko <alex@millerson.name>
To:     Dominick Grift <dac.override@gmail.com>
Cc:     <selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ssh: Add interface =?iso-8859-1?Q?ssh=5Fsearch=5Fdir?=
Date:   Thu, 20 Jun 2019 18:38:10 +0300
MIME-Version: 1.0
Message-ID: <d15b7000-6866-46bb-8622-33c7cad5cc4b@millerson.name>
In-Reply-To: <20190620152731.GD2647@brutus.lan>
References: <20190620144138.15172-1-alex@millerson.name>
 <20190620144138.15172-3-alex@millerson.name>
 <20190620145011.GC2647@brutus.lan>
 <642ea6d9-97c9-4ec4-a7ed-84995a953b48@millerson.name>
 <20190620152731.GD2647@brutus.lan>
User-Agent: Trojita/0.7; Qt/5.12.3; xcb; Linux; Gentoo Base System release 2.6
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On =D1=87=D0=B5=D1=82=D0=B2=D0=B5=D1=80=D0=B3, 20 =D0=B8=D1=8E=D0=BD=D1=8F 20=
19 =D0=B3. 18:27:31 MSK, Dominick Grift wrote:
> On Thu, Jun 20, 2019 at 06:05:57PM +0300, Alexander Miroshnichenko wrote:
>> On =D1=87=D0=B5=D1=82=D0=B2=D0=B5=D1=80=D0=B3, 20 =D0=B8=D1=8E=D0=BD=D1=8F=
 2019 =D0=B3. 17:50:11 MSK, Dominick Grift wrote: ...
>
> Yes this sucks. I would probably do the following instead:
>
> 1. echo "ignoredirs=3D/var/lib/gitolite" >> /etc/selinux/semanage.conf
> 2. semodule -B && restorecon -RvF /var/lib/gitolite
> 3. gitosis_read_lib_files(sshd_t)

I can't use sshd_t in another policy without require statement.
Or I need to add gitosis_read_lib_files(sshd_t) to ssh.te policy file.
All 3 steps are ugly comparing with new ssh_search_dir() interface.
Why such restrictions where caller must be the source for interface? It is=20=

not flexible.

>
> Dont bother with labeling /var/lib/gitolite/.ssh differently
>
>>  ...
>