Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Aug 2019 22:02:43 +0200
From:   Dominick Grift <dac.override@gmail.com>
To:     Nicolas Iooss <nicolas.iooss@m4x.org>
Cc:     selinux-refpolicy@vger.kernel.org
Subject: Re: Why is /usr/include matched with /usr/inclu.e?
Message-ID: <20190821200243.GA5262@brutus.lan>
Mail-Followup-To: Nicolas Iooss <nicolas.iooss@m4x.org>,
        selinux-refpolicy@vger.kernel.org
References: <CAJfZ7=krh_TaCBQzFxLM394Sc5-82ZO0DdcfvWON-RXu-wqBVw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62"
Content-Disposition: inline
In-Reply-To: <CAJfZ7=krh_TaCBQzFxLM394Sc5-82ZO0DdcfvWON-RXu-wqBVw@mail.gmail.com>
User-Agent: Every email client sucks, this one just sucks less.
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk


--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Aug 21, 2019 at 09:57:14PM +0200, Nicolas Iooss wrote:
> Hi all,
>=20
> While checking the patterns in refpolicy, I stumbled upon the
> following line in
> https://github.com/SELinuxProject/refpolicy/blob/RELEASE_2_20190609/polic=
y/modules/kernel/files.fc#L200
>=20
> /usr/inclu.e(/.*)? gen_context(system_u:object_r:usr_t,s0)

Probably to work around an m4-ism. There seems to be an m4 "include" built-=
in.

>=20
> This pattern matches /usr/include and its content, but why is a dot
> used? Which other directories can it match?
>=20
> The issue there is that a dot can match a slash, so the pattern also
> matches /usr/inclu/e/, which seems strange. This pattern has been
> introduced in the very early days of refpolicy's git repository,
> according to https://github.com/SELinuxProject/refpolicy/commit/f8ec0ad43=
b54437e2d9f0e48a773a64dbd9e543c#diff-e333cb52d2139f7a71f0dfbd32c06f70R117.
> Does anyone remember why the pattern for /usr/include is so special?
>=20
> Thanks,
> Nicolas
>=20

--=20
Key fingerprint =3D 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02
https://sks-keyservers.net/pks/lookup?op=3Dget&search=3D0x3B6C5F1D2C7B6B02
Dominick Grift

--+QahgC5+KEYLbs62
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCAAdFiEEujmXliIBLFTc2Y4AJXSOVTf5R2kFAl1do14ACgkQJXSOVTf5
R2nidwv/cBN7C5AWIILzwKm91F9nBujYgg1azcP17is3pLezip2eEPwx4ai0xrm0
dNdFBXGBSgJf3ANpuMaoG2kKtGOiDJZN+8MjVWcAOmO3VF+OS5fMVIHaGu80Uuoa
Hyfven+prmd+tjoudbl8u6PWZqfidIX20qS8NAwONzhWDs6IbiELZ9Yh95Pg9Oe0
ZFW2+fsM4EDQXfCQFXJYXxhNoK7Abw6gugNYBhfdamlU8ei35GSUeyDG/392RRBC
//si8WeIi0d0RcMx1MA5k3hSVI6XToli3yVhPXk+6iwPF7qEWWGGoFCPw3mDPB7G
Crt8X8k9N5oearQwJn27olgFYsApdDT65VUzSIfBadGwkTTWkGKftAP7qu9MQyc5
kZIaOl++I1ymWn/wK+Ydu2CRCpxAEynmzCMBkY5FDP19kDNSrQWkTomj2jieNwbU
5RLwKhzmuGaKB+yhVKyNDshTqq3sy6IeQt1GzqxCKQdEH1V5asRXeuHugG1BrX/D
oLfcAh7P
=3aiE
-----END PGP SIGNATURE-----

--+QahgC5+KEYLbs62--