Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: Adding a typo-checker for the .fc files of refpolicy
To:     Nicolas Iooss <nicolas.iooss@m4x.org>,
        selinux-refpolicy@vger.kernel.org
References: <CAJfZ7=ndO=f0p6Gb=5FaZWA05Ra8vrSnDGfwmCjepLs3SWVrcg@mail.gmail.com>
 <CAJfZ7=nFPG6SKmR7q__Cp8=YawkayCrhZtsr5RX5FC2pa8PU5Q@mail.gmail.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <a22349ba-246e-e3cc-aa56-a7407b52d1e4@ieee.org>
Date:   Tue, 27 Aug 2019 00:05:04 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAJfZ7=nFPG6SKmR7q__Cp8=YawkayCrhZtsr5RX5FC2pa8PU5Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 8/18/19 4:38 PM, Nicolas Iooss wrote:
> Hello,
> 
> After introducing a buggy file context in the policy (which will be
> fixed with https://github.com/SELinuxProject/refpolicy/pull/66), I
> decided to write a typo-checker for the .fc files. I am re-using some
> code I have already written in order to label files in /usr/bin
> correctly on Arch Linux (I wrote this for
> https://github.com/SELinuxProject/refpolicy/pull/19). It seems it
> already caught another issue in policy/modules/services/monit.fc. The
> "s9" seems to be a misspelling for "s0" in:
> 
> /etc/rc\.d/init\.d/monit --
> gen_context(system_u:object_r:monit_initrc_exec_t,s9)
> 
> Is there an interest in having such a script in the repository? If

What are the checks?


> yes, in which directory?
> 
> In my humble opinion, it would be nice to have such a script and to
> make Travis-CI run it. I nevertheless feels uncomfortable with putting
> it in the "support" directory, because it is not involved in building
> or installing the reference policy. I am therefore suggesting creating
> a new directory, named "bin" or "scripts". Such a directory would
> contain scripts such as this typo-checker and some other scripts that
> could be useful when working on refpolicy. What do you think about
> this?

"testing" might work too.

-- 
Chris PeBenito