Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 4 Sep 2019 09:25:10 +0200
From:   Dominick Grift <dac.override@gmail.com>
To:     selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] Remove shell automatic domain transitions to
 unconfined_t from various pam login programs
Message-ID: <20190904072510.GB923044@brutus.lan>
Mail-Followup-To: selinux-refpolicy@vger.kernel.org
References: <20190901124620.375409-1-dac.override@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="eJnRUKwClWJh1Khz"
Content-Disposition: inline
In-Reply-To: <20190901124620.375409-1-dac.override@gmail.com>
User-Agent: Every email client sucks, this one just sucks less.
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk


--eJnRUKwClWJh1Khz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Sep 01, 2019 at 02:46:20PM +0200, Dominick Grift wrote:
> I think these may have been adopted from the old Red Hat targeted policy =
(that model only had unconfined users)

Was this overlooked?

>=20
> Some aspect to note:
>=20
> 1. The ssh_sysadm_login boolean now applies to unconfined_t as well
> 2. remotelogin only allows unpriv logins
>=20
> The rshd module also calls unconfined_shell_domtrans() but I ignored that=
 one because that policy currently does not have support for manual transit=
ions with pam_selinux.
>=20
> Signed-off-by: Dominick Grift <dac.override@gmail.com>
> ---
>  policy/modules/services/remotelogin.te | 4 ----
>  policy/modules/services/ssh.te         | 4 ----
>  policy/modules/system/locallogin.te    | 4 ----
>  3 files changed, 12 deletions(-)
>=20
> diff --git a/policy/modules/services/remotelogin.te b/policy/modules/serv=
ices/remotelogin.te
> index bc2292e3..c7c9c564 100644
> --- a/policy/modules/services/remotelogin.te
> +++ b/policy/modules/services/remotelogin.te
> @@ -91,10 +91,6 @@ optional_policy(`
>  	telnet_use_ptys(remote_login_t)
>  ')
> =20
> -optional_policy(`
> -	unconfined_shell_domtrans(remote_login_t)
> -')
> -
>  optional_policy(`
>  	usermanage_read_crack_db(remote_login_t)
>  ')
> diff --git a/policy/modules/services/ssh.te b/policy/modules/services/ssh=
=2Ete
> index 4e75b6e1..a99ad912 100644
> --- a/policy/modules/services/ssh.te
> +++ b/policy/modules/services/ssh.te
> @@ -328,10 +328,6 @@ optional_policy(`
>  	systemd_dbus_chat_logind(sshd_t)
>  ')
> =20
> -optional_policy(`
> -	unconfined_shell_domtrans(sshd_t)
> -')
> -
>  optional_policy(`
>  	xserver_domtrans_xauth(sshd_t)
>  	xserver_link_xdm_keys(sshd_t)
> diff --git a/policy/modules/system/locallogin.te b/policy/modules/system/=
locallogin.te
> index a56f3d1f..632d2542 100644
> --- a/policy/modules/system/locallogin.te
> +++ b/policy/modules/system/locallogin.te
> @@ -200,10 +200,6 @@ optional_policy(`
>  	systemd_write_inherited_logind_sessions_pipes(local_login_t)
>  ')
> =20
> -optional_policy(`
> -	unconfined_shell_domtrans(local_login_t)
> -')
> -
>  optional_policy(`
>  	usermanage_read_crack_db(local_login_t)
>  ')
> --=20
> 2.23.0
>=20

--=20
Key fingerprint =3D 5F4D 3CDB D3F8 3652 FBD8 02D5 3B6C 5F1D 2C7B 6B02
https://sks-keyservers.net/pks/lookup?op=3Dget&search=3D0x3B6C5F1D2C7B6B02
Dominick Grift

--eJnRUKwClWJh1Khz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCAAdFiEEujmXliIBLFTc2Y4AJXSOVTf5R2kFAl1vZtIACgkQJXSOVTf5
R2m+Kwv+KkpJ7hW/lpVNEm/Puq9XKDIgCkFF7EcNLz15DtrGsB3qq/WaVEv5CE1R
tfMee1k/b2WVRsTTdYKIF44NSCvw8SucTd4BJHh15RB1HZ3BQ1vyOOALEPxTcZVH
/2ksFS/BN0BENeFRFB3rcl4MWOSRImmTdvUfSi6/NmIBfZ+6xzbkoOC1VeYNEc7j
y3bYFWz2EP994trH5dQAWjJuoiqsCyGSPl8rpT6nZqeJnwkovJ655IzTf7w2FYVc
n/EmqNDQoRAN+vq7MRRDx1RYx7KeG0UKuby+QHqYgzRlHhlVA10Ujl/UcMZucbuV
vvXXfueOu02qJyzJnlp0fqs8diSRbKr9VFb9pRyJqNQVfPQbWutW3RgNuwK/HR3M
zTB455gxMsYTxCbDkiZ9XlamwngrVN+1oix76XYSTD31xeiT4ctHHESOELxdvoDI
hZVqqlTnxdyfL37b9mYmi40ptQQPMW7C1nDl0NAPvz2l9qrBk7QjT+zb4e3qXzFs
x5mp1W+Q
=yjlo
-----END PGP SIGNATURE-----

--eJnRUKwClWJh1Khz--