Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC] Rename *_var_run_t to *_runtime_t
To:     Nicolas Iooss <nicolas.iooss@m4x.org>
Cc:     refpolicy <selinux-refpolicy@vger.kernel.org>
References: <581e9bcc-b5f9-1219-c520-d4dbf2b5f9eb@ieee.org>
 <CAJfZ7=khMjHJ01jCXkrTZ2sCypGjW9ZP2fZ0NOYTvynDFQhRCw@mail.gmail.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <7a4077a7-e889-226a-26c3-891db800755d@ieee.org>
Date:   Mon, 16 Sep 2019 20:52:32 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <CAJfZ7=khMjHJ01jCXkrTZ2sCypGjW9ZP2fZ0NOYTvynDFQhRCw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 9/15/19 6:33 AM, Nicolas Iooss wrote:
> On Sat, Sep 14, 2019 at 11:52 PM Chris PeBenito <pebenito@ieee.org> wrote:
>>
>> /var/run has moved to /run on most systems and it's use has increased
>> beyond pid files and sockets. Because of this, new types used in /run
>> have for some time followed the convention *_runtime_t. This change
>> would rename all *_var_run_t types to *_runtime_t.
>>
>> Since this adds many aliases to the policy, the patch set also drops all
>> old backwards-compatibility aliases.
>>
>> https://github.com/SELinuxProject/refpolicy/pull/106
>>
>> Any objections to this?
> 
> Hello,
> I agree with this change.
> 
> When I loaded the policy with your patch on my test system, my kernel
> logs issued a warning:
> 
> SELinux:  Context sysadm_u:sysadm_r:samba_net_t became invalid (unmapped).
> SELinux:  Context sysadm_u:sysadm_r:smbcontrol_t became invalid (unmapped).
> SELinux:  Context sysadm_u:sysadm_r:winbind_helper_t became invalid (unmapped).
> 
> This is because the following optional block from sysadm.te is now dropped:
> 
> optional_policy(`
> samba_admin(sysadm_t, sysadm_r)
> samba_run_smbcontrol(sysadm_t, sysadm_r)
> samba_run_smbmount(sysadm_t, sysadm_r)
> samba_run_net(sysadm_t, sysadm_r)
> samba_run_winbind_helper(sysadm_t, sysadm_r)
> ')
> 
> This block is dropped because it required two types that are not
> defined: nmbd_runtime_t and smbd_runtime_t.
> 
> In the current refpolicy (git master), there is:
> 
> typealias samba_var_run_t alias { nmbd_var_run_t smbd_var_run_t };
> 
> Your pull request changes this to:
> 
> typealias samba_runtime_t alias { nmbd_var_run_t smbd_var_run_t };
> 
> Should nmbd_runtime_t and smbd_runtime_t be changed to samba_runtime_t
> in interface samba_admin()?

Yes. There was another interface that also had that issue.  I updated 
the PR to fix it.


> Other than that, I did not find other issues.
> 
> Thanks,
> Nicolas
> 


-- 
Chris PeBenito