Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp10030320ybl; Thu, 26 Dec 2019 09:30:09 -0800 (PST) X-Google-Smtp-Source: APXvYqyTKD4LCvtXI3jOly95bWvnSf6Ho8LBDjpLUx3alup8PQSgvpdN/xsgQt2Fm9jrNSi+r11g X-Received: by 2002:a05:6830:3c3:: with SMTP id p3mr35017593otc.146.1577381409283; Thu, 26 Dec 2019 09:30:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577381409; cv=none; d=google.com; s=arc-20160816; b=rlGbl6Vri12OEFJEzpeq2kV5IgqJ/JVgYxOlKGM1k3YBClDpmACECsXTgJdO2E2c0J FfedtTJv3jOreSlV/DERxEAgq5k2b7Xg1brnDG7+nfHTQENujxxKsfstPDc3MMAsly2f cEtmhnwucMbrUDMOI5Mm8ABq/lk9gG9O5HueSjaOZk2KGfJeKk9MZQfgZvou/gZOYW43 jXlLnizS8F03KoN/mdylH5UuD23C6AiXtn+EduO+h0ExfOlDiKBVl0gCSfGK0qQ1tc/a dtcJumK5LfluQ1DKLvlzh2g96z5n0vXxdloH9wEML8H4sUFr674vfCO5H+WDncpPar09 Qn2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=TcB4CA4kmflAp0IJ2g0B4mlIRM1ECUhB+9dV7UNo+oM=; b=yXv+l54zJ+Df+pQEVUi8SvNNyrKQPB/toLGW2/enS+Lm/TImp9Nd6L6emt47+ydE7D 10VmR+ieTR9e4GHGywOXV8TVujhWvkWGIJ4QTYzhvpFiCiTE8Pp84UcVhoIVA1GA2Nq1 H+QoLaQXO1+IQd46OKW/YM44ajPbEo2uTO39ip451w+AopMV4fwoJEQKTZxcU+GGjyQ4 11gHfYqZjptqVg4pTdk6JxiMeEC9K7TUgGSZqazgpp/3EYSgiyRsKNudatxCpFJd9Dti 9cBSY0l7rNC5a5EO44mD4Wnhs2uuqYg4urmb8Wwsp05fkCVUZrk5XrdWyuN41rGCVUdg cFyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ieee.org header.s=google header.b="U4J1q5/y"; spf=pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=selinux-refpolicy-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ieee.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t14si10539235otp.210.2019.12.26.09.30.07; Thu, 26 Dec 2019 09:30:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ieee.org header.s=google header.b="U4J1q5/y"; spf=pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=selinux-refpolicy-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ieee.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726752AbfLZRaH (ORCPT + 11 others); Thu, 26 Dec 2019 12:30:07 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:43053 "EHLO mail-qv1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726480AbfLZRaG (ORCPT ); Thu, 26 Dec 2019 12:30:06 -0500 Received: by mail-qv1-f65.google.com with SMTP id p2so9242173qvo.10 for ; Thu, 26 Dec 2019 09:30:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=TcB4CA4kmflAp0IJ2g0B4mlIRM1ECUhB+9dV7UNo+oM=; b=U4J1q5/y7iHRvCDgwo0hJocqboFSOyHBb+3DQ7WwsGKuAWxmFozWzuYijIqipO2q56 MXNLc2nuohZIRL5YDNJQBdp8ImKGA5nY/7ibgHiUgsOfmI5oOpK8xn3hnvoRkpbAHtOt PhoNoCI8fzXmjTUYGz3L/zaOk5YmVmTc0JAww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TcB4CA4kmflAp0IJ2g0B4mlIRM1ECUhB+9dV7UNo+oM=; b=Ipgg5kB/9+lvQnX1syrwLJJa+E8stHz3GSB7zKGPcIq6WKaBPk6dflh+5fGcbWgwQe uUL+MNkXOwWvBjsHA16l0TsksFypg/8Na14foHaBvk5bSW45E+L3GY+06Y1FRGajIgza 1epOLudpjxB1p4G/6QEO/OC/HbV9yDeI+FzLzSiF7DuKwhZw3PMVYabOdo0SApxsflH5 bN7Us4MGKYeo/34nRtbyMHlIhWrcxSF0HFHWuHnrCjMW6ZiRpND/68vNvW+Gwf1qpWir erv85UB6T3I2lKHb/suyLI1HzTNAyPqEZN/mXPeFG7OLMKeYrz+Pqefd/c60jTgYWC+g J0Ag== X-Gm-Message-State: APjAAAUgtTS10yxOrY9KBa9L7sOLGDzlVTyz8cavcBBgklqTcoDrgQlv RBQ98ZXDVyP5p2GwU+c8Jmfkkz8JxRM= X-Received: by 2002:ad4:4dc9:: with SMTP id cw9mr38068810qvb.0.1577381405553; Thu, 26 Dec 2019 09:30:05 -0800 (PST) Received: from fedora.pebenito.net (pool-108-15-23-247.bltmmd.fios.verizon.net. [108.15.23.247]) by smtp.gmail.com with ESMTPSA id b42sm3362856qtb.36.2019.12.26.09.30.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Dec 2019 09:30:05 -0800 (PST) Subject: Re: [PATCH 9/9] virt: allow lvm_control access To: Jason Zaman , selinux-refpolicy@vger.kernel.org References: <20191224101043.58122-1-jason@perfinion.com> <20191224101043.58122-9-jason@perfinion.com> From: Chris PeBenito Message-ID: Date: Thu, 26 Dec 2019 12:28:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191224101043.58122-9-jason@perfinion.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On 12/24/19 5:10 AM, Jason Zaman wrote: > type=AVC msg=audit(1563034372.505:40675): avc: denied { read write } for pid=64033 comm="libvirtd" name="control" dev="devtmpfs" ino=1273 scontext=system_u:system_r:virtd_t:s0-s0:c0.c1023 tcontext=system_u:object_r:lvm_control_t:s0 tclass=chr_file permissive=0 > type=SYSCALL msg=audit(1563034372.505:40675): arch=c000003e syscall=257 success=no exit=-13 a0=ffffff9c a1=7ff9a09cd180 a2=2 a3=0 items=1 ppid=1 pid=64033 auid=1000 uid=0 gid=0 euid=0 suid=0 fsuid=0 egid=0 sgid=0 fsgid=0 tty=(none) ses=3 comm="libvirtd" exe="/usr/sbin/libvirtd" subj=system_u:system_r:virtd_t:s0-s0:c0.c1023 key=(null) > type=CWD msg=audit(1563034372.505:40675): cwd="/" > type=PATH msg=audit(1563034372.505:40675): item=0 name="/dev/mapper/control" inode=1273 dev=00:06 mode=020600 ouid=0 ogid=0 rdev=0a:ec obj=system_u:object_r:lvm_control_t:s0 nametype=NORMAL cap_fp=0 cap_fi=0 cap_fe=0 cap_fver=0 cap_frootid=0 > > Signed-off-by: Jason Zaman > --- > policy/modules/services/virt.te | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/policy/modules/services/virt.te b/policy/modules/services/virt.te > index d4c5d05a..fb985f12 100644 > --- a/policy/modules/services/virt.te > +++ b/policy/modules/services/virt.te > @@ -622,6 +622,7 @@ dev_rw_sysfs(virtd_t) > dev_read_urand(virtd_t) > dev_read_rand(virtd_t) > dev_rw_kvm(virtd_t) > +dev_rw_lvm_control(virtd_t) > dev_getattr_all_chr_files(virtd_t) > dev_rw_mtrr(virtd_t) > dev_rw_vhost(virtd_t) Merged. -- Chris PeBenito