Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AZrdbExW4/cpfiGTFvV9k7uAGtYjV8LGtZVwlr6?=
 =?us-ascii?q?E/grcLSJyIuqrYZRSDtKdThVPEFb/W9+hDw7KP9fy5BSpYvN3Y6itKMMQVEU?=
 =?us-ascii?q?Nc0oNOx01oKfXGIHWzFOTtYS0+EZYKf35e1Fb/D3JoHt3jbUbZuHy44G1aMB?=
 =?us-ascii?q?z+MQ1oOra9QdaK3Iy42O+o5pLcfRhDiiajbrNuNhW2qhjautULjYd4Jas91x?=
 =?us-ascii?q?TErmFUd+lWym9kOEyfkhjh7cu04JJv7j5ctv08+8NOS6n2Y7g0QblFBzk6Lm?=
 =?us-ascii?q?4549HmuwPeRgWV/HscVWsWkhtMAwfb6RzxQ4n8vCjnuOdjwSeWJcL5Q6w6Vj?=
 =?us-ascii?q?Sk9KdrVQTniDwbOD4j8WHYkdJ/gaRGqx+8vRN/worUYIaINPpie67WYN0XSX?=
 =?us-ascii?q?ZdUstXSidMGZ23YZcRAOUdPOZYt4j9qEUIrRuiHgmnGefjxiZVinPqwaE21u?=
 =?us-ascii?q?IsHg/c3AwkAtkArnLaotvoP6sWSOy4wq3FwTDFYvhL2zny9ZLIfwg8r/+SU7?=
 =?us-ascii?q?J+ccnfx0chGAzKjFqftYPrMiiJ1ukPqWWX8/ZsWOyvhmMhtgp/oiKvxsApio?=
 =?us-ascii?q?TRhIIUxEzL+j9jwIYpO9GzVUl2YdyqEZRMrS6aLZd2Tt05TmF0uCc11r0GuZ?=
 =?us-ascii?q?mhcCgM05Qo3QTTa/OAc4iW+x/uUvuaLzl/hHJgYr2/hhCy/FCvyu39Ssm00E?=
 =?us-ascii?q?tKoTFfntbQsXAN0hre4dWERPtl5kqtxDmC2g/J5uxEPEw4j7TXJpE/zrIqi5?=
 =?us-ascii?q?Yet1nIEDXsl0XslqCWc10p+u2v6+v6fLrrvoScN4poigHmNaQuh9C/Dfw4Mg?=
 =?us-ascii?q?cQW2ib/vyx1KH58k3jQbVKk+Y2nrPYsJDcK8QbobW5DBFJ3Yo59xa+Dyup0N?=
 =?us-ascii?q?QfnXUdKlJKZAmHgJTzN1HLIfD4Ce+zg1WqkDh12/DLJqDtD5rCI3TZkLrtYK?=
 =?us-ascii?q?xx51BTxQYt19xT+opYCrQbL/LyXk/xusbYDhg8MwGswebmBsly2ZkEWWKTHK?=
 =?us-ascii?q?OUK7/SsF+U6eIvJOmAfokVuC3nJPQ/6P7uimE5lUcHfaa1xZsXdGy4HvN+Lk?=
 =?us-ascii?q?qEenXsn80BEWgUsQo4UuPqkkaPUSJJZ3msRKI95io7BJi6AofEQ4CnmKaB0z?=
 =?us-ascii?q?ujHp1KemBGDUiBEWz2eIWAWvcMbj+SI8B4njweS7ehRZch1RaqtA/717VmLv?=
 =?us-ascii?q?HZ+jMXtZ39zth5/e7Tmg8o9TxyEcud13uBT2ZunmMHFHcK2/U1i1FnxVqF3L?=
 =?us-ascii?q?I8y9BRE91e47kBBgswKITTwup3EfjuQA/ab8zPQ1GjFJHuSyo8StM33s9LeU?=
 =?us-ascii?q?tzA9KmjxvS9zSlDqVTlLGRApEwtKXG0DK5c91wz3fAyblklVQoWsxLNGa3rr?=
 =?us-ascii?q?Bw+hKVBIPTlUid0aGwevJP8jTK8TKB0mGHpl0CGFpyTq7MR2xFTlfHptT+oE?=
 =?us-ascii?q?XZRvmhDqpxYVgJ8tKLNqYfMo6htl5BXvq2fY2FMm8=3D?=
Subject: Re: [Non-DoD Source] SELint
To:     "Burgener, Daniel" <dburgener@tresys.com>,
        "selinux-refpolicy@vger.kernel.org" 
        <selinux-refpolicy@vger.kernel.org>
References: <53806485-18fe-0cd8-ca16-9cdb495cdb92@tresys.com>
From:   jwcart2 <jwcart2@tycho.nsa.gov>
Message-ID: <f0ee635f-e68f-23cb-451a-03e3066d7a67@tycho.nsa.gov>
Date:   Thu, 16 Jan 2020 14:52:31 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <53806485-18fe-0cd8-ca16-9cdb495cdb92@tresys.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 1/16/20 9:37 AM, Burgener, Daniel wrote:
> Hello,
> 
> We have created a tool a that I think people on this list may find very
> useful as they do refpolicy related work.  It's called SELint and does
> static code analysis on refpolicy style SELinux policy.  You can find
> the tool on our git repo here:
> 
> https://github.com/TresysTechnology/selint
> 
> It currently has 13 checks for common policy issues, and we hope to add
> more going forward.
> 
> I submitted a pull request to the refpolicy github this morning that
> fixes some of the issues reported by the tool, and hope to continue
> submitting more over the next few days.
> 
> -Daniel
> 

Interesting work. Some of the tests are similar to those in a tool I created in 
2018, selpoltools (https://github.com/jwcart2/selpoltools), but I did not think 
of doing a check for a potentially unescaped regex character. I like that your 
tool is written in c and that you can disable individual checks with a command 
line option.

A couple of comments (which you are probably aware of)
- You will need to teach your program about object_r at some point.

- I ran it on a Refpolicy source tree from earlier in the year and it complained 
about system_u being a non-existent user in the fc files, even though it is 
defined in users.

- I am a little bit confused by what the line out of order (C-001) wants. For 
example, I get the following two warnings

ipsec.te:       118: (C): Line out of order.  It is before line 124 that calls 
an interface located in the kernel module. (C-001)
ipsec.te:       119: (C): Line out of order.  It is before line 124 that is in a 
different section.  (This node is in the section for ipsec_mgmt_t rules and the 
other is in the section for ipsec_t rules.) (C-001)

118 corecmd_shell_domtrans(ipsec_t, ipsec_mgmt_t)
119 allow ipsec_mgmt_t ipsec_t:fd use;
. . .
124 kernel_read_kernel_sysctls(ipsec_t)
125 kernel_rw_net_sysctls(ipsec_t)
126 kernel_* ...

I am guessing that it wants the ipsec_t rules before the ipsec_mgmt_t rules?
I wonder why there aren't similar warnings referring to lines 125-134 which also 
refer to kernel interfaces. I am guessing that it recognizes line 124 as the 
start of the ipsec_t section?


All in all, it looks promising.
Jim

-- 
James Carter <jwcart2@tycho.nsa.gov>
National Security Agency