Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC] files: Make files_{relabel,manage}_non_security_types work
 on all file types
To:     Henrik Grindal Bakken <hgb@ifi.uio.no>,
        selinux-refpolicy@vger.kernel.org
References: <20200117231500.59904-1-hgb@ifi.uio.no>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <aee925e5-1a1f-1c97-71eb-669ff5890392@ieee.org>
Date:   Tue, 21 Jan 2020 08:36:50 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20200117231500.59904-1-hgb@ifi.uio.no>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 1/17/20 6:15 PM, Henrik Grindal Bakken wrote:
> From: Henrik Grindal Bakken <henribak@cisco.com>
> 
> This is the same behavious as files_*_non_auth_types have.
> ---
>   policy/modules/kernel/files.if | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/policy/modules/kernel/files.if b/policy/modules/kernel/files.if
> index f1c9441..255d8a9 100644
> --- a/policy/modules/kernel/files.if
> +++ b/policy/modules/kernel/files.if
> @@ -652,7 +652,11 @@ interface(`files_manage_non_security_files',`
>   		attribute non_security_file_type;
>   	')
>   
> +	manage_dirs_pattern($1, non_security_file_type, non_security_file_type)
>   	manage_files_pattern($1, non_security_file_type, non_security_file_type)
> +	manage_lnk_files_pattern($1, non_security_file_type, non_security_file_type)
> +	manage_fifo_files_pattern($1, non_security_file_type, non_security_file_type)
> +	manage_sock_files_pattern($1, non_security_file_type, non_security_file_type)
>   ')
>   
>   ########################################
> @@ -671,7 +675,11 @@ interface(`files_relabel_non_security_files',`
>   		attribute non_security_file_type;
>   	')
>   
> +	relabel_dirs_pattern($1, non_security_file_type, non_security_file_type)
>   	relabel_files_pattern($1, non_security_file_type, non_security_file_type)
> +	relabel_lnk_files_pattern($1, non_security_file_type, non_security_file_type)
> +	relabel_fifo_files_pattern($1, non_security_file_type, non_security_file_type)
> +	relabel_sock_files_pattern($1, non_security_file_type, non_security_file_type)
>   ')
>   
>   ########################################

NAK.  Access per object class is already split up across separate 
interfaces, so doing this would be confusing and prevent someone from 
getting file-only access.

-- 
Chris PeBenito