Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Allow audit daemon to halt system
To:     "Sugar, David" <dsugar@tresys.com>,
        "selinux-refpolicy@vger.kernel.org" 
        <selinux-refpolicy@vger.kernel.org>
References: <20200113182743.3502993-1-dsugar@tresys.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <57feca94-255a-b04f-597b-462d4eb0b6e9@ieee.org>
Date:   Tue, 21 Jan 2020 08:38:35 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20200113182743.3502993-1-dsugar@tresys.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 1/13/20 1:28 PM, Sugar, David wrote:
> auditd can halt the system for several reasons based on configuration.
> These mostly revovle around audit partition full issues.  I am seeing
> the following denials when attempting to halt the system.
> 
> Jan 12 03:38:48 localhost audispd: node=localhost type=USER_AVC msg=audit(1578800328.122:1943): pid=1 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 msg='avc:  denied  { start } for auid=n/a uid=0 gid=0 path="/usr/lib/systemd/system/poweroff.target" cmdline="/sbin/init 0" scontext=system_u:system_r:auditd_t:s0 tcontext=system_u:object_r:power_unit_t:s0 tclass=service exe="/usr/lib/systemd/systemd" sauid=0 hostname=? addr=? terminal=?'
> Jan 12 03:38:48 localhost audispd: node=localhost type=USER_AVC msg=audit(1578800328.147:1944): pid=1 uid=0 auid=4294967295 ses=4294967295 subj=system_u:system_r:init_t:s0 msg='avc:  denied  { status } for auid=n/a uid=0 gid=0 path="/usr/lib/systemd/system/poweroff.target" cmdline="/sbin/init 0" scontext=system_u:system_r:auditd_t:s0 tcontext=system_u:object_r:power_unit_t:s0 tclass=service exe="/usr/lib/systemd/systemd" sauid=0 hostname=? addr=? terminal=?'
> Jan 12 04:44:54 localhost audispd: node=localhost type=AVC msg=audit(1578804294.103:1923): avc:  denied  { getattr } for  pid=6936 comm="systemctl" path="/run/systemd/system" dev="tmpfs" ino=45 scontext=system_u:system_r:auditd_t:s0 tcontext=system_u:object_r:systemd_unit_t:s0 tclass=dir permissive=1
> 
> Signed-off-by: Dave Sugar <dsugar@tresys.com>
> ---
>   policy/modules/system/logging.te |  6 ++++++
>   policy/modules/system/systemd.if | 20 ++++++++++++++++++++
>   2 files changed, 26 insertions(+)
> 
> diff --git a/policy/modules/system/logging.te b/policy/modules/system/logging.te
> index 73ca3042..69349af0 100644
> --- a/policy/modules/system/logging.te
> +++ b/policy/modules/system/logging.te
> @@ -224,6 +224,12 @@ ifdef(`distro_ubuntu',`
>   	')
>   ')
>   
> +ifdef(`init_systemd',`

I think in this case an optional would be sufficient due to the 
systemd_* interface use.


> +	init_list_unit_dirs(auditd_t)
> +	systemd_start_power_units(auditd_t)
> +	systemd_status_power_units(auditd_t)
> +')
> +
>   optional_policy(`
>   	mta_send_mail(auditd_t)
>   ')
> diff --git a/policy/modules/system/systemd.if b/policy/modules/system/systemd.if
> index 0fd37fe8..2e9098a2 100644
> --- a/policy/modules/system/systemd.if
> +++ b/policy/modules/system/systemd.if
> @@ -773,6 +773,26 @@ interface(`systemd_start_power_units',`
>   	allow $1 power_unit_t:service start;
>   ')
>   
> +########################################
> +## <summary>
> +##	Get the system status information about power units
> +## </summary>
> +## <param name="domain">
> +##	<summary>
> +##	Domain allowed access.
> +##	</summary>
> +## </param>
> +#
> +interface(`systemd_status_power_units',`
> +	gen_require(`
> +		type power_unit_t;
> +		class service status;
> +	')
> +
> +	allow $1 power_unit_t:service status;
> +')
> +
> +
>   ########################################
>   ## <summary>
>   ##	Make the specified type usable for
> 


-- 
Chris PeBenito