Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 01/10] fstools: add zfs-auto-snapshot
To:     Jason Zaman <jason@perfinion.com>,
        selinux-refpolicy@vger.kernel.org
Cc:     Jason Zaman <perfinion@gentoo.org>
References: <20200216200319.39337-1-jason@perfinion.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <1afd8a7c-336c-2385-e9d4-1475f62c3f58@ieee.org>
Date:   Mon, 17 Feb 2020 13:26:51 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20200216200319.39337-1-jason@perfinion.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 2/16/20 3:03 PM, Jason Zaman wrote:
> Should be in domain fstools_t, and needs to run zpool which is
> mount_exec_t.
> 
> type=AVC msg=audit(1563084061.269:2472): avc:  denied  { execute } for  pid=4981 comm="env" name="zpool" dev="zfs" ino=259064 scontext=system_u:system_r:fsadm_t:s0-s0:c0.c1023 tcontext=system_u:object_r:mount_exec_t:s0 tclass=file permissive=0
> type=SYSCALL msg=audit(1563084061.269:2472): arch=c000003e syscall=59 success=no exit=-13 a0=7ffeba786e70 a1=7ffeba787098 a2=55726a69a4e0 a3=7fbff7eb5b00 items=1 ppid=4980 pid=4981 auid=4294967295 uid=0 gid=0 euid=0 suid=0 fsuid=0 egid=0 sgid=0 fsgid=0 tty=(none) ses=4294967295 comm="env" exe="/bin/env" subj=system_u:system_r:fsadm_t:s0-s0:c0.c1023 key=(null)
> type=CWD msg=audit(1563084061.269:2472): cwd="/root"
> type=PATH msg=audit(1563084061.269:2472): item=0 name="/sbin/zpool" inode=259064 dev=00:17 mode=0100755 ouid=0 ogid=0 rdev=00:00 obj=system_u:object_r:mount_exec_t:s0 nametype=NORMAL cap_fp=0 cap_fi=0 cap_fe=0 cap_fver=0 cap_frootid=0
> 
> Signed-off-by: Jason Zaman <jason@perfinion.com>
> Signed-off-by: Jason Zaman <perfinion@gentoo.org>
> ---
>   policy/modules/system/fstools.fc | 1 +
>   policy/modules/system/fstools.te | 2 ++
>   2 files changed, 3 insertions(+)
> 
> diff --git a/policy/modules/system/fstools.fc b/policy/modules/system/fstools.fc
> index 8fbd5ce4..d871294e 100644
> --- a/policy/modules/system/fstools.fc
> +++ b/policy/modules/system/fstools.fc
> @@ -49,6 +49,7 @@
>   /usr/bin/swapon.*		--	gen_context(system_u:object_r:fsadm_exec_t,s0)
>   /usr/bin/tune2fs		--	gen_context(system_u:object_r:fsadm_exec_t,s0)
>   /usr/bin/zdb			--	gen_context(system_u:object_r:fsadm_exec_t,s0)
> +/usr/bin/zfs-auto-snapshot	--	gen_context(system_u:object_r:fsadm_exec_t,s0)
>   /usr/bin/zhack			--	gen_context(system_u:object_r:fsadm_exec_t,s0)
>   /usr/bin/zinject		--	gen_context(system_u:object_r:fsadm_exec_t,s0)
>   /usr/bin/zpios			--	gen_context(system_u:object_r:fsadm_exec_t,s0)
> diff --git a/policy/modules/system/fstools.te b/policy/modules/system/fstools.te
> index 4ad6e65f..4ae0301a 100644
> --- a/policy/modules/system/fstools.te
> +++ b/policy/modules/system/fstools.te
> @@ -154,6 +154,8 @@ logging_send_syslog_msg(fsadm_t)
>   
>   miscfiles_read_localization(fsadm_t)
>   
> +# for zfs/zpool
> +mount_exec(fsadm_t)
>   # for /run/mount/utab
>   mount_getattr_runtime_files(fsadm_t)
>   # losetup: bind mount_loopback_t files to loop devices

Merged.

-- 
Chris PeBenito