Received: by 2002:a25:1506:0:0:0:0:0 with SMTP id 6csp5022534ybv; Mon, 17 Feb 2020 10:34:59 -0800 (PST) X-Google-Smtp-Source: APXvYqzv2a7pLgNF5n+vHSjcJbf/fu3rEF7+MHTvIil1h0vHA/yYhVsjMQa6f4j/i//dz3232ZVn X-Received: by 2002:a05:6808:181:: with SMTP id w1mr239749oic.176.1581964499646; Mon, 17 Feb 2020 10:34:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1581964499; cv=none; d=google.com; s=arc-20160816; b=QxD+FS56f73SalKkyIJecoLuG0Hz3Pl92pBxzzYAaMTbuKCSQ3uujjwO0+ohxO68Ev O4ceq5nnwRmyfvWC32YFIN6cyD9qrHBgNe8ffavHhkWtCLDo6PJYkK8hRpMXAoaiY5G0 UQyQJ59wfvrs4rMHj9VQ3TRNbTfaSI+1KSuLVMwxwKfp2jirkSFiBiu3fpe3c9QTR/nN pd5cSnJ2QbRt76Se65gmZmPbAbq3hgXvF5cFv0qh4uYqS4Tn0FWvdRJ9jyo+I9pzUpJU XmxX25J9wGk+ZMTApBBUD0v/VtCkpoHyX67rRUqWCbsmIFgy0nmRybLRaebeXNTKYrPN lblg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=VCbDgOeeNgChUap/1wALXQS49p22sxtRwbisD0eF7C8=; b=EdGfaSd2oUqIERdtZcWBCbdm2+BAxVAN6gp5EWAvAwRAzkowV8jxxSkJ6S7DqArTAS K3f5w73E9aWLqKA9vhukX5/Hvw5GaHbS/F1qDYXdx3AhEn41v6hFVx6EUyKd9EO19Ixf DX3/3sc39FDVJeEvaatPA4uL403dE0cwiGj0Lev/B1aL4WXjcUygLj1oZGOoHiQHjvUl HaLEIPnFJVVdWMHAq/2TCPdx3maNDRiQMh4z2aqUIa37fLvDz4Hv7M2AW3fN9rntiGyA L1E3hhxO4a+07vYUWdjormh0xPLtHv5KDW5DoGeyPjwRDsqa/95xT7eZzBq4J8EYv/g8 Wu6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ieee.org header.s=google header.b=P7xuyZvM; spf=pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=selinux-refpolicy-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ieee.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f14si509219oto.46.2020.02.17.10.34.57; Mon, 17 Feb 2020 10:34:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ieee.org header.s=google header.b=P7xuyZvM; spf=pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=selinux-refpolicy-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ieee.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728958AbgBQSej (ORCPT + 13 others); Mon, 17 Feb 2020 13:34:39 -0500 Received: from mail-qv1-f66.google.com ([209.85.219.66]:39172 "EHLO mail-qv1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727179AbgBQSej (ORCPT ); Mon, 17 Feb 2020 13:34:39 -0500 Received: by mail-qv1-f66.google.com with SMTP id y8so8000388qvk.6 for ; Mon, 17 Feb 2020 10:34:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ieee.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=VCbDgOeeNgChUap/1wALXQS49p22sxtRwbisD0eF7C8=; b=P7xuyZvMGseFDLF700Fww+RihcICooBl9KTGTAgMQG8SoB0UKULPkJePQ2Mlo+7L8B E/JpAxwIri3rAbPAiiRe7l/Asr6wo/3bUNy7WxMKoWo56Xn6H5pK3UmUpmygZzH1nzXM xqI/57m0Pqok/6Tae8gNHjRL1paS9OupPETfc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=VCbDgOeeNgChUap/1wALXQS49p22sxtRwbisD0eF7C8=; b=LWa2x3pmMsCKaFaTurs9z9xEKlQOFB3otw2l/RD6DQbb7gCwMZqsfBuIis6HWcKUxB NQkguGub8zbg0xhV7VPakUnhWYNv1f6fD54CXVyWuw+x+xlOX6rSMFi3oo4OQy80SvIF ctBF5kAkl3H4GwZS/17cUAQBskypUuEvx42ifacI6/my5hp5ncQpW81irkMPvUWIlwko iyCkn4jNHmH5vxZQiyMCtDh3dX6Amt4WskGPcEd33djIB6p4Z4jpHfnwfB6+S13hWpEC HrcqKlVWM+IkZR6BU/lldHu+gwVxK9gYGyLoHX2xBgozCL8j/qrIoVFFumLqZpwWqcHv Xe/g== X-Gm-Message-State: APjAAAUBth2otI87Zk5bWMjqauZRt/UwIOkmwIBDgBBoTbuYN17J7zVM +sFjNGDy8R6PmulIW5D7HkMLKAVvoyQ= X-Received: by 2002:a05:6214:17cd:: with SMTP id cu13mr13102565qvb.192.1581964478718; Mon, 17 Feb 2020 10:34:38 -0800 (PST) Received: from fedora.pebenito.net (pool-108-15-23-247.bltmmd.fios.verizon.net. [108.15.23.247]) by smtp.gmail.com with ESMTPSA id l10sm623673qke.93.2020.02.17.10.34.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Feb 2020 10:34:38 -0800 (PST) Subject: Re: [PATCH 05/10] colord: add watch perms To: Jason Zaman , selinux-refpolicy@vger.kernel.org References: <20200216200319.39337-1-jason@perfinion.com> <20200216200319.39337-5-jason@perfinion.com> From: Chris PeBenito Message-ID: <53498f4d-1b18-c73f-22fd-b930a3798474@ieee.org> Date: Mon, 17 Feb 2020 13:27:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <20200216200319.39337-5-jason@perfinion.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org On 2/16/20 3:03 PM, Jason Zaman wrote: > avc: denied { watch } for pid=12656 comm="gmain" path="/var/lib/colord/icc" dev="zfs" ino=100677 scontext=system_u:system_r:colord_t:s0-s0:c0.c1023 tcontext=system_u:object_r:colord_var_lib_t:s0 tclass=dir permissive=0 > avc: denied { watch } for pid=12656 comm="gmain" path="/usr/share/color/icc/colord" dev="zfs" ino=67586 scontext=system_u:system_r:colord_t:s0-s0:c0.c1023 tcontext=system_u:object_r:usr_t:s0 tclass=dir permissive=0 > Signed-off-by: Jason Zaman > --- > policy/modules/services/colord.te | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/policy/modules/services/colord.te b/policy/modules/services/colord.te > index 24eda8a9..44f2b049 100644 > --- a/policy/modules/services/colord.te > +++ b/policy/modules/services/colord.te > @@ -42,6 +42,7 @@ fs_tmpfs_filetrans(colord_t, colord_tmpfs_t, { dir file }) > manage_dirs_pattern(colord_t, colord_var_lib_t, colord_var_lib_t) > manage_files_pattern(colord_t, colord_var_lib_t, colord_var_lib_t) > files_var_lib_filetrans(colord_t, colord_var_lib_t, dir) > +allow colord_t colord_var_lib_t:dir watch; > > kernel_read_crypto_sysctls(colord_t) > kernel_read_device_sysctls(colord_t) > @@ -82,6 +83,7 @@ domain_use_interactive_fds(colord_t) > files_list_mnt(colord_t) > files_read_usr_files(colord_t) > files_map_usr_files(colord_t) > +files_watch_usr_dirs(colord_t) > > fs_getattr_noxattr_fs(colord_t) > fs_getattr_tmpfs(colord_t) Merged. -- Chris PeBenito