Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 06/10] policykit devicekit: Add watch perms
To:     Jason Zaman <jason@perfinion.com>,
        selinux-refpolicy@vger.kernel.org
References: <20200216200319.39337-1-jason@perfinion.com>
 <20200216200319.39337-6-jason@perfinion.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <6a095c4f-6323-5ade-0aae-88d3f10c770d@ieee.org>
Date:   Mon, 17 Feb 2020 13:28:26 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20200216200319.39337-6-jason@perfinion.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 2/16/20 3:03 PM, Jason Zaman wrote:
> avc:  denied  { watch } for  pid=12488 comm="gmain" path="/etc" dev="zfs" ino=1436 scontext=system_u:system_r:devicekit_disk_t:s0-s0:c0.c1023 tcontext=system_u:object_r:etc_t:s0 tclass=dir permissive=0
> avc:  denied  { watch } for  pid=6452 comm="gmain" path="/run/ConsoleKit" dev="tmpfs" ino=17611 scontext=system_u:system_r:policykit_t:s0-s0:c0.c1023 tcontext=system_u:object_r:consolekit_runtime_t:s0 tclass=dir permissive=0
> avc:  denied  { watch } for  pid=6452 comm="gmain" path="/usr/share/polkit-1/actions" dev="zfs" ino=235638 scontext=system_u:system_r:policykit_t:s0-s0:c0.c1023 tcontext=system_u:object_r:usr_t:s0 tclass=dir permissive=0
> avc:  denied  { watch } for  pid=6452 comm="gmain" path="/etc/polkit-1/rules.d" dev="zfs" ino=268215 scontext=system_u:system_r:policykit_t:s0-s0:c0.c1023 tcontext=system_u:object_r:etc_t:s0 tclass=dir permissive=0
> Signed-off-by: Jason Zaman <jason@perfinion.com>
> ---
>   policy/modules/services/consolekit.if | 18 ++++++++++++++++++
>   policy/modules/services/devicekit.te  |  1 +
>   policy/modules/services/policykit.te  |  3 +++
>   3 files changed, 22 insertions(+)
> 
> diff --git a/policy/modules/services/consolekit.if b/policy/modules/services/consolekit.if
> index 9aa0dbce..422c19cd 100644
> --- a/policy/modules/services/consolekit.if
> +++ b/policy/modules/services/consolekit.if
> @@ -121,3 +121,21 @@ interface(`consolekit_read_pid_files',`
>   	allow $1 consolekit_runtime_t:dir list_dir_perms;
>   	read_files_pattern($1, consolekit_runtime_t, consolekit_runtime_t)
>   ')
> +
> +########################################
> +## <summary>
> +##	Watch consolekit runtime dir.
> +## </summary>
> +## <param name="domain">
> +##	<summary>
> +##	Domain allowed access.
> +##	</summary>
> +## </param>
> +#
> +interface(`consolekit_watch_runtime_dir',`
> +	gen_require(`
> +		type consolekit_runtime_t;
> +	')
> +
> +	allow $1 consolekit_runtime_t:dir watch;
> +')
> diff --git a/policy/modules/services/devicekit.te b/policy/modules/services/devicekit.te
> index f58a7a19..ed88f10b 100644
> --- a/policy/modules/services/devicekit.te
> +++ b/policy/modules/services/devicekit.te
> @@ -127,6 +127,7 @@ files_manage_boot_dirs(devicekit_disk_t)
>   files_manage_mnt_dirs(devicekit_disk_t)
>   files_read_etc_runtime_files(devicekit_disk_t)
>   files_read_usr_files(devicekit_disk_t)
> +files_watch_etc_dirs(devicekit_disk_t)
>   
>   fs_getattr_all_fs(devicekit_disk_t)
>   fs_list_inotifyfs(devicekit_disk_t)
> diff --git a/policy/modules/services/policykit.te b/policy/modules/services/policykit.te
> index 04e88500..4989157c 100644
> --- a/policy/modules/services/policykit.te
> +++ b/policy/modules/services/policykit.te
> @@ -95,6 +95,8 @@ dev_read_urand(policykit_t)
>   domain_read_all_domains_state(policykit_t)
>   
>   files_dontaudit_search_all_mountpoints(policykit_t)
> +files_watch_etc_dirs(policykit_t)
> +files_watch_usr_dirs(policykit_t)
>   
>   fs_getattr_xattr_fs(policykit_t)
>   fs_list_inotifyfs(policykit_t)
> @@ -127,6 +129,7 @@ optional_policy(`
>   
>   optional_policy(`
>   	consolekit_read_pid_files(policykit_t)
> +	consolekit_watch_runtime_dir(policykit_t)
>   ')
>   
>   optional_policy(`

Merged.

-- 
Chris PeBenito