Received: by 2002:a25:6193:0:0:0:0:0 with SMTP id v141csp1190616ybb; Fri, 10 Apr 2020 20:06:26 -0700 (PDT) X-Received: by 2002:a0c:b9a5:: with SMTP id v37mr3494070qvf.154.1586574146060; Fri, 10 Apr 2020 20:02:26 -0700 (PDT) X-Google-Smtp-Source: APiQypJD9JbPfLrlxwsjRcFhZft/N0Tb3Ybet9xHfc9Ltc4CfoRIwbkSTVWXsLOyNeAawsWoXfZ+ X-Received: by 2002:a0c:b9a5:: with SMTP id v37mr3494011qvf.154.1586574144899; Fri, 10 Apr 2020 20:02:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586574144; cv=none; d=google.com; s=arc-20160816; b=NBXFYWcTdipOvmAkT6Ox00xhJ5iwqDLLeMGfkhOWjqU4vQ8zpaXPpqgvzQ3O2FGDxB lq6LeIcsbP2KH/sl4oRkZxzlVYcmwGZhZeQfVkjqMUBY0RajKn6u2tBGVsiFsNaQDy8d aeytcOQHgoMmXhMF7AfoJdpMenWbuBaeKVQzdMS213zPmz6+82HbL0bSTZFnTbGG0YsB z6ImN62ttEf5NBwKbOWG9BJFayMFw6BWvidgTzIDhVbIvUNAtYzOfwDvZDZok8SqGHe6 +LweCqbFHfKTC/D5lEQjTl/bACNuzlpDUKWIIzb1o8lFsGZHz44Gw+kVzzePBaZoNvcs V93g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=WQ1lZDM6Hz28wkaxXVjkQPvbIXK3Rte9hxQcM4dHdkQ=; b=rX4yPdzlkXwNWmlddMquApCZA8YOqPQvfxLsHUosmZAHDw0VfFXscIzw5Gbl1Q4IPt OC0JVobJIYvEN1mhQUU2o+T/VpfvTYHhGb8aPRN/McuvHrCWIdYEmYRQfY0+eXwMZ1BN pKi4s0sERJ6tUWNLJPVbrJh1IJF3Kr3jLeAV+4etALXkATPq+2JMe/IBlV9rqcjarpd+ bUqkYwWtjXdmIhvfjUB7M/ec7LkkyuE2SwJyGFkVn1xDBF4Me0CTSEmJl3QmlLaiQIjA lLg+9kPO/DBDto906LdK/quxe3g+0J7iPUoaAzBfcrIAX///wU0bjJfk623KPAu97iGj 4f/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@coker.com.au header.s=2008 header.b=LKUCWYKC; spf=pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=selinux-refpolicy-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=coker.com.au Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h14si2194893qte.101.2020.04.10.20.02.19; Fri, 10 Apr 2020 20:02:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@coker.com.au header.s=2008 header.b=LKUCWYKC; spf=pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=selinux-refpolicy-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=coker.com.au Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbgDKDCS (ORCPT + 13 others); Fri, 10 Apr 2020 23:02:18 -0400 Received: from smtp.sws.net.au ([46.4.88.250]:38468 "EHLO smtp.sws.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726657AbgDKDCS (ORCPT ); Fri, 10 Apr 2020 23:02:18 -0400 Received: from liv.localnet (localhost [127.0.0.1]) by smtp.sws.net.au (Postfix) with ESMTP id 25ABEEC7C for ; Sat, 11 Apr 2020 13:02:15 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=coker.com.au; s=2008; t=1586574136; bh=WQ1lZDM6Hz28wkaxXVjkQPvbIXK3Rte9hxQcM4dHdkQ=; l=1108; h=From:To:Subject:Date:From; b=LKUCWYKCWp26UekQFHdYsMBN5ZxOGatu6ycq4b/m3aaDKrpNgLnHRY9NCpHdnyqTB RdZrPjdDOE4Yfag3yMfplmaEUsDCyt4L9383gyMLp0rU+rPqH+Oe2Pia/vc6OgKw+7 35rlx1erFCgztj+0Z3dS2qvehSfpN2ajTaZzL41A= From: Russell Coker To: selinux-refpolicy@vger.kernel.org Subject: systemd_generator_t vs systemd_generator_type Date: Sat, 11 Apr 2020 13:02:10 +1000 Message-ID: <1717302.MpC4nazLU5@liv> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: selinux-refpolicy-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: selinux-refpolicy@vger.kernel.org This combination of names is confusing. As a general rule I think we shouldn't have a type name be a substring of an attribute name. Having an attribute name as a substring of a type name is less of an issue but still best avoided. /lib/systemd/system-generators/systemd-bless-boot-generator /lib/systemd/system-generators/systemd-cryptsetup-generator /lib/systemd/system-generators/systemd-debug-generator /lib/systemd/system-generators/systemd-getty-generator /lib/systemd/system-generators/systemd-hibernate-resume-generator /lib/systemd/system-generators/systemd-rc-local-generator /lib/systemd/system-generators/systemd-run-generator /lib/systemd/system-generators/systemd-system-update-generator /lib/systemd/system-generators/systemd-veritysetup-generator /usr/lib/systemd/user-environment-generators/30-systemd-environment-d- generator Above are the generators on my system that run as systemd_generator_t. Would systemd_generator_generic_t/systemd_generator_generic_exec_t be an OK name? -- My Main Blog http://etbe.coker.com.au/ My Documents Blog http://doc.coker.com.au/