Received-SPF: pass (google.com: best guess record for domain of selinux-refpolicy-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: systemd_generator_t vs systemd_generator_type
To:     Russell Coker <russell@coker.com.au>,
        selinux-refpolicy@vger.kernel.org
References: <1717302.MpC4nazLU5@liv>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <ee3f03ff-d42b-9507-668b-36e22aadeb3d@ieee.org>
Date:   Tue, 14 Apr 2020 11:06:07 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.6.0
MIME-Version: 1.0
In-Reply-To: <1717302.MpC4nazLU5@liv>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: selinux-refpolicy-owner@vger.kernel.org
Precedence: bulk

On 4/10/20 11:02 PM, Russell Coker wrote:
> This combination of names is confusing.  As a general rule I think we
> shouldn't have a type name be a substring of an attribute name.  Having an
> attribute name as a substring of a type name is less of an issue but still
> best avoided.
> 
> /lib/systemd/system-generators/systemd-bless-boot-generator
> /lib/systemd/system-generators/systemd-cryptsetup-generator
> /lib/systemd/system-generators/systemd-debug-generator
> /lib/systemd/system-generators/systemd-getty-generator
> /lib/systemd/system-generators/systemd-hibernate-resume-generator
> /lib/systemd/system-generators/systemd-rc-local-generator
> /lib/systemd/system-generators/systemd-run-generator
> /lib/systemd/system-generators/systemd-system-update-generator
> /lib/systemd/system-generators/systemd-veritysetup-generator
> /usr/lib/systemd/user-environment-generators/30-systemd-environment-d-
> generator
> 
> Above are the generators on my system that run as systemd_generator_t.  Would
> systemd_generator_generic_t/systemd_generator_generic_exec_t be an OK name?

I'd accept a patch for this.

-- 
Chris PeBenito