Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] xen: Allow xenstored to map /proc/xen/xsd_kva
To:     Anthony PERARD <anthony.perard@citrix.com>,
        selinux-refpolicy@vger.kernel.org
References: <20201027172228.528204-1-anthony.perard@citrix.com>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <ed3d59a2-5d2b-e4cb-6677-f35a45b66bac@ieee.org>
Date:   Thu, 5 Nov 2020 06:55:54 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20201027172228.528204-1-anthony.perard@citrix.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 10/27/20 1:22 PM, Anthony PERARD wrote:
> xenstored is using mmap() on /proc/xen/xsd_kva, and when the SELinux
> boolean "domain_can_mmap_files" in CentOS is set to false the mmap()
> call fails.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> v2: Declare an interface instead of using allow in xen.te directly.
> ---
>   policy/modules/kernel/filesystem.if | 18 ++++++++++++++++++
>   policy/modules/system/xen.te        |  1 +
>   2 files changed, 19 insertions(+)
> 
> diff --git a/policy/modules/kernel/filesystem.if b/policy/modules/kernel/filesystem.if
> index b52fc769236b..b85ae2f6e851 100644
> --- a/policy/modules/kernel/filesystem.if
> +++ b/policy/modules/kernel/filesystem.if
> @@ -5310,6 +5310,24 @@ interface(`fs_manage_xenfs_files',`
>   	manage_files_pattern($1, xenfs_t, xenfs_t)
>   ')
>   
> +########################################
> +## <summary>
> +##	Map files a XENFS filesystem.
> +## </summary>
> +## <param name="domain">
> +##	<summary>
> +##	Domain allowed access.
> +##	</summary>
> +## </param>
> +#
> +interface(`fs_mmap_xenfs_files',`
> +	gen_require(`
> +		type xenfs_t;
> +	')
> +
> +	allow $1 xenfs_t:file map;
> +')
> +
>   ########################################
>   ## <summary>
>   ##	Do not audit attempts to create,
> diff --git a/policy/modules/system/xen.te b/policy/modules/system/xen.te
> index 2c95d0ca3bbd..82328cbbbaa3 100644
> --- a/policy/modules/system/xen.te
> +++ b/policy/modules/system/xen.te
> @@ -459,6 +459,7 @@ files_read_usr_files(xenstored_t)
>   
>   fs_search_xenfs(xenstored_t)
>   fs_manage_xenfs_files(xenstored_t)
> +fs_mmap_xenfs_files(xenstored_t)
>   
>   term_use_generic_ptys(xenstored_t)

Merged.

-- 
Chris PeBenito