Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Russell Coker <russell@coker.com.au>
To:     Dominick Grift <dominick.grift@defensec.nl>
Cc:     selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] misc network patches with Dominick's changes
Date:   Thu, 28 Jan 2021 03:35:33 +1100
Message-ID: <3290098.uLzDavUzRi@liv>
In-Reply-To: <ypjl8s8ejyoj.fsf@defensec.nl>
References: <YBESacEBUo/hzFVH@xev> <ypjl8s8ejyoj.fsf@defensec.nl>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On Thursday, 28 January 2021 12:29:16 AM AEDT Dominick Grift wrote:
> > Index: refpolicy-2.20210126/policy/modules/system/sysnetwork.fc
> > ===================================================================
> > --- refpolicy-2.20210126.orig/policy/modules/system/sysnetwork.fc
> > +++ refpolicy-2.20210126/policy/modules/system/sysnetwork.fc
> > @@ -27,6 +27,7 @@ ifdef(`distro_debian',`
> > 
> >  /etc/dhcp3?/dhclient.*		gen_context(system_u:object_r:dhcp_etc_t,s0)
> >  
> >  /etc/systemd/network(/.*)?	gen_context(system_u:object_r:net_conf_t,s0)
> > 
> > +/etc/tor/torsocks.conf	--	gen_context(system_u:object_r:net_conf_t,s0)
> 
> minor but bet to escape the period: /etc/tor/torsocks\.conf

OK fixed that.
 
> not sure why you associate this with net_conf_t. I probably would have
> labeled all of /etc/tor tor_conf_t (for confined tor administration etc)

Because other programs that want to use tor look at it for information on how 
to connect to tor via socks.

> > Index: refpolicy-2.20210126/policy/modules/roles/unprivuser.te
> > ===================================================================
> > --- refpolicy-2.20210126.orig/policy/modules/roles/unprivuser.te
> > +++ refpolicy-2.20210126/policy/modules/roles/unprivuser.te
> > @@ -25,6 +25,10 @@ optional_policy(`
> > 
> >  ')
> >  
> >  optional_policy(`
> > 
> > +	netutils_domtrans_ping(user_t)
> > +')
> 
> this is already allowed conditionally as said before. you should be able
> to remove this.

OK, removed that.

I'll send another patch now.

-- 
My Main Blog         http://etbe.coker.com.au/
My Documents Blog    http://doc.coker.com.au/