Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] misc services patches with changes Dominick and Chris
 wanted
To:     Russell Coker <russell@coker.com.au>,
        selinux-refpolicy@vger.kernel.org
References: <YBDa5ga6QMQtfoVH@xev>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <cc0d9501-86ac-1bc6-bc6b-c3be85febaf3@ieee.org>
Date:   Thu, 28 Jan 2021 10:50:45 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <YBDa5ga6QMQtfoVH@xev>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 1/26/21 10:15 PM, Russell Coker wrote:
> I think this one is ready to merge.
> 
> Signed-off-by: Russell Coker <russell@coker.com.au>

Merged.

I've added a new mmap_manage_files_pattern() macro and applied it to the changes.


> @@ -899,6 +909,7 @@ optional_policy(`
>   #
>   
>   read_files_pattern(httpd_helper_t, httpd_config_t, httpd_config_t)
> +allow httpd_t httpd_config_t:file map;


I assumed this was a typo and the source type was httpd_helper_t instead of httpd_t.


> Index: refpolicy-2.20210126/policy/modules/services/cron.te
> ===================================================================
> --- refpolicy-2.20210126.orig/policy/modules/services/cron.te
> +++ refpolicy-2.20210126/policy/modules/services/cron.te
> @@ -304,6 +304,8 @@ init_start_all_units(system_cronjob_t)
>   init_get_generic_units_status(system_cronjob_t)
>   init_get_system_status(system_cronjob_t)
>   
> +backup_manage_store_files(system_cronjob_t)

I made this optional.

There were a few other lines that I moved around.

-- 
Chris PeBenito