Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Dominick Grift <dominick.grift@defensec.nl>
To:     Nicolas Iooss <nicolas.iooss@m4x.org>
Cc:     Russell Coker <russell@coker.com.au>,
        Chris PeBenito <pebenito@ieee.org>,
        refpolicy <selinux-refpolicy@vger.kernel.org>
Subject: Re: [PATCH] misc services patches with changes Dominick and Chris
 wanted
References: <YBDa5ga6QMQtfoVH@xev>
        <80d12d35-93b2-9227-eb4e-de0e2942654c@ieee.org>
        <ypjleei5hu26.fsf@defensec.nl>
        <CAJfZ7===nm6YpDnjH4WQko=O=NS5z3pFb82crq4++JimUsxHYA@mail.gmail.com>
Date:   Thu, 28 Jan 2021 18:41:50 +0100
In-Reply-To: <CAJfZ7===nm6YpDnjH4WQko=O=NS5z3pFb82crq4++JimUsxHYA@mail.gmail.com>
        (Nicolas Iooss's message of "Thu, 28 Jan 2021 18:34:41 +0100")
Message-ID: <ypjla6sthsbl.fsf@defensec.nl>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Nicolas Iooss <nicolas.iooss@m4x.org> writes:

> On Thu, Jan 28, 2021 at 6:07 PM Dominick Grift
> <dominick.grift@defensec.nl> wrote:
>>
>> Chris PeBenito <pebenito@ieee.org> writes:
>>
>> > On 1/26/21 10:15 PM, Russell Coker wrote:
>> >> I think this one is ready to merge.
>> >> Signed-off-by: Russell Coker <russell@coker.com.au>
>> >
>> >
>> >> @@ -170,6 +172,7 @@ ifdef(`distro_suse',`
>> >>   /var/log/roundcubemail(/.*)?
>> >> gen_context(system_u:object_r:httpd_log_t,s0)
>> >>   /var/log/suphp\.log.* --
>> >> gen_context(system_u:object_r:httpd_log_t,s0)
>> >>   /var/log/z-push(/.*)?
>> >> gen_context(system_u:object_r:httpd_sys_rw_content_t,s0)
>> >> +/var/log/php7..-fpm.log --
>> >> gen_context(system_u:object_r:httpd_log_t,s0)
>> >
>> > selint flagged this.  Is ".." intended to be 2 "." metacharacters?
>>
>> I would probably just do: /var/log/php.*-fpm\.log.* and get it over with
>
> Or /var/log/php[0-9.]+-fpm\.log to match "something that looks like a
> version". The problem with "." is that it can match a "/", for
> subdirectories.

BTW One might wonder why i use the .* suffix. That is to support log rotation.

>
> Nicolas
>

-- 
gpg --locate-keys dominick.grift@defensec.nl
Key fingerprint = FCD2 3660 5D6B 9D27 7FC6  E0FF DA7E 521F 10F6 4098
https://sks-keyservers.net/pks/lookup?op=get&search=0xDA7E521F10F64098
Dominick Grift