Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] new version of filetrans patch
To:     Russell Coker <russell@coker.com.au>
Cc:     selinux-refpolicy@vger.kernel.org
References: <YBeKKR5cmQe+MTRA@xev>
 <983ff6fa-2bbc-22f1-a72c-a4eb38127f09@ieee.org> <2243812.pyNZXzfhlh@liv>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <4ba452f1-2dd6-810b-665e-f648e7bdc967@ieee.org>
Date:   Tue, 2 Feb 2021 13:28:59 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <2243812.pyNZXzfhlh@liv>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/2/21 9:42 AM, Russell Coker wrote:
> On Wednesday, 3 February 2021 12:49:07 AM AEDT Chris PeBenito wrote:
>>> Name changes suggested by Dominick and some more additions.
>>>
>>> Signed-off-by: Russell Coker <russell@coker.com.au>
>>
>> Merged, though I renamed some interfaces and dropped a block that didn't
>> apply since it's so close to the merge window closing.
> 
> +interface(`systemd_run_passwd_agent',`
> +       gen_require(`
> +               type systemd_passwd_agent_t, systemd_passwd_agent_exec_t;
> +       ')
> +
> +       domain_auto_transition_pattern($1, systemd_passwd_agent_exec_t,
> systemd_passwd_agent_t)
> +       allow systemd_passwd_agent_t $1:fd use;
> +       role $2 types systemd_passwd_agent_t;
> +')
> 
> Why did you change the above to the below?  It needs an auto trans.
> 
> interface(`systemd_run_passwd_agent',`
>          gen_require(`
>                  type systemd_passwd_agent_t, systemd_passwd_agent_exec_t;
>          ')
> 
>          domtrans_pattern($1, systemd_passwd_agent_exec_t,
> systemd_passwd_agent_t)
>          allow systemd_passwd_agent_t $1:fd use;
>          role $2 types systemd_passwd_agent_t;
> ')

domtrans_pattern() is automatic.

-- 
Chris PeBenito