Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] rasdaemon (replacement for mcelog)
To:     Dominick Grift <dominick.grift@defensec.nl>,
        Russell Coker <russell@coker.com.au>
Cc:     selinux-refpolicy@vger.kernel.org
References: <YEWNyIsSThUoVAsc@xev> <ypjl7dmija7e.fsf@defensec.nl>
 <ypjl35x6ja14.fsf@defensec.nl>
From:   Chris PeBenito <pebenito@ieee.org>
Message-ID: <cd3be651-38de-9998-7dc6-2c6f0f20277e@ieee.org>
Date:   Fri, 12 Mar 2021 10:03:48 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <ypjl35x6ja14.fsf@defensec.nl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/8/21 3:59 AM, Dominick Grift wrote:
> Dominick Grift <dominick.grift@defensec.nl> writes:
> 
>> Russell Coker <russell@coker.com.au> writes:
>>
>>> This is policy for rasdaemon, the new replacement for mcelog.  The
>>> /dev/mcelog device is now an obsolete kernel feature that can be enabled
>>> for backward compatibility and rasdaeon with tracefs is the new way.
>>>
>>> I've tested this and it seems to work OK, but all my servers are working
>>> well so I haven't been able to test the case of actually detecting an
>>> error.  It would be good if someone with a known damaged server could give
>>> it a go.
>>>
>>> I think this is ready for merging.
>>>
>>> Signed-off-by: Russell Coker <russell@coker.com.au>
>>>
[...]
>>> +++ refpolicy-2.20210203/policy/modules/services/rasdaemon.te
>>> @@ -0,0 +1,49 @@
>>> +policy_module(rasdaemon, 1.0.0)
>>> +
>>> +# rasdaemon is a RAS (Reliability, Availability and Serviceability) logging
>>> +# tool.  It currently records memory errors, using the EDAC tracing events.
>>> +# EDAC are drivers in the Linux kernel that handle detection of ECC errors
>>> +# from memory controllers for most chipsets on x86 and ARM architectures.
>>> +#
>>> +# https://git.infradead.org/users/mchehab/rasdaemon.git
>>
>> Please use the <summary></summary> for description. We have an api
>> browser (make doc) and the description should end up there as well.
>>
>> <summary>Reliability, Availability and Serviceability (RAS) logging tool.</summary>
>>
>> I would omit the url because those are often subject to change anyway.

I agree if we have this amount of description it should go in the XML, but the 
module level actually has a <desc> tag that goes after <summary>.  I like 
Dominick's summary, but the Russel's comment can go in the module <desc>.

The URL can remain.  Yes, it can change, but at least there are some breadcrumbs 
if this program becomes obsolete or unmaintained.

-- 
Chris PeBenito