Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8b79c7da-e7be-024f-bd6e-7f9f41ff7a4a@ieee.org>
Date:   Wed, 16 Feb 2022 06:40:07 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH] dontaudit net_admin
Content-Language: en-US
To:     Russell Coker <russell@coker.com.au>,
        selinux-refpolicy@vger.kernel.org
References: <YgjbycsVKXR6GEGl@xev.coker.com.au>
From:   Chris PeBenito <pebenito@ieee.org>
In-Reply-To: <YgjbycsVKXR6GEGl@xev.coker.com.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/13/22 05:22, Russell Coker wrote:
> This patch has dontaudit rules for some net_admin accesses that are from
> changing buffer sizes.  The programs in question work fine like this.
> 
> I think this is worthy of inclusion.
> 
> Signed-off-by: Russell Coker <russell@coker.com.au>

I'm onboard with the rule additions but am unsure on the the broken symptoms.  I 
I'm unsure having that block has real value, since it's always on and I've never 
heard anyone turning it off.


> Index: refpolicy-2.20220106/policy/modules/services/cron.te
> ===================================================================
> --- refpolicy-2.20220106.orig/policy/modules/services/cron.te
> +++ refpolicy-2.20220106/policy/modules/services/cron.te
> @@ -176,6 +176,10 @@ tunable_policy(`fcron_crond',`
>   # Daemon local policy
>   #
>   
> +ifdef(`hide_broken_symptoms',`
> +# for changing buffer sizes
> +dontaudit crond_t self:capability net_admin;
> +')
>   allow crond_t self:capability { chown dac_override dac_read_search fowner setgid setuid sys_nice sys_resource };
>   dontaudit crond_t self:capability { sys_tty_config };
>   
> Index: refpolicy-2.20220106/policy/modules/services/dbus.te
> ===================================================================
> --- refpolicy-2.20220106.orig/policy/modules/services/dbus.te
> +++ refpolicy-2.20220106/policy/modules/services/dbus.te
> @@ -71,6 +71,10 @@ ifdef(`enable_mls',`
>   # Local policy
>   #
>   
> +ifdef(`hide_broken_symptoms',`
> +# for changing buffer sizes
> +dontaudit system_dbusd_t self:capability net_admin;
> +')
>   allow system_dbusd_t self:capability { dac_override setgid setpcap setuid sys_resource };
>   dontaudit system_dbusd_t self:capability sys_tty_config;
>   allow system_dbusd_t self:process { getattr getsched signal_perms setpgid getcap setcap setrlimit };
> Index: refpolicy-2.20220106/policy/modules/services/policykit.te
> ===================================================================
> --- refpolicy-2.20220106.orig/policy/modules/services/policykit.te
> +++ refpolicy-2.20220106/policy/modules/services/policykit.te
> @@ -68,6 +68,10 @@ miscfiles_read_localization(policykit_do
>   # Local policy
>   #
>   
> +ifdef(`hide_broken_symptoms',`
> +# for changing buffer sizes
> +dontaudit policykit_t self:capability net_admin;
> +')
>   allow policykit_t self:capability { dac_override dac_read_search setgid setuid sys_nice sys_ptrace };
>   allow policykit_t self:process { getsched setsched signal };
>   allow policykit_t self:unix_stream_socket { accept connectto listen };
> Index: refpolicy-2.20220106/policy/modules/services/postfix.te
> ===================================================================
> --- refpolicy-2.20220106.orig/policy/modules/services/postfix.te
> +++ refpolicy-2.20220106/policy/modules/services/postfix.te
> @@ -107,6 +107,10 @@ mta_mailserver_delivery(postfix_virtual_
>   # Common postfix domain local policy
>   #
>   
> +ifdef(`hide_broken_symptoms',`
> +# for changing buffer sizes
> +dontaudit postfix_domain self:capability net_admin;
> +')
>   allow postfix_domain self:capability { sys_chroot sys_nice };
>   dontaudit postfix_domain self:capability sys_tty_config;
>   allow postfix_domain self:process { signal_perms setpgid setsched };


-- 
Chris PeBenito