Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6947f06f-6a39-e6da-eac3-68e06ebb2ec4@linux.microsoft.com>
Date:   Wed, 16 Feb 2022 10:46:44 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.0
Subject: Re: [PATCH] init dbus patch for GetDynamicUsers
Content-Language: en-US
To:     Russell Coker <russell@coker.com.au>,
        selinux-refpolicy@vger.kernel.org
References: <Ygz380hW5LYcm6aL@xev.coker.com.au>
From:   Chris PeBenito <chpebeni@linux.microsoft.com>
In-Reply-To: <Ygz380hW5LYcm6aL@xev.coker.com.au>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/16/2022 08:11, Russell Coker wrote:
> Small patches for dbus access to talk to init for getting dynamic users
> with systemd.  The daemons do such checks from library code.
> 
> Signed-off-by: Russell Coker <russell@coker.com.au>
> 
> Index: refpolicy-2.20220216/policy/modules/services/dictd.te
> ===================================================================
> --- refpolicy-2.20220216.orig/policy/modules/services/dictd.te
> +++ refpolicy-2.20220216/policy/modules/services/dictd.te
> @@ -79,3 +79,6 @@ optional_policy(`
>   	seutil_sigchld_newrole(dictd_t)
>   ')
>   
> +ifdef(`init_systemd',`
> +	init_dbus_chat(dictd_t)
> +')
> Index: refpolicy-2.20220216/policy/modules/services/postfix.te
> ===================================================================
> --- refpolicy-2.20220216.orig/policy/modules/services/postfix.te
> +++ refpolicy-2.20220216/policy/modules/services/postfix.te
> @@ -376,9 +376,6 @@ manage_lnk_files_pattern(postfix_bounce_
>   
>   optional_policy(`
>   	init_dbus_chat(postfix_bounce_t)
> -')
> -
> -optional_policy(`
>   	dbus_system_bus_client(postfix_bounce_t)
>   ')
>   
> @@ -754,6 +751,11 @@ optional_policy(`
>   	unconfined_run_to(postfix_showq_t, postfix_showq_exec_t)
>   ')
>   
> +ifdef(`init_systemd',`
> +	init_dbus_chat(postfix_showq_t)
> +	dbus_system_bus_client(postfix_showq_t)
> +')
> +
>   ########################################
>   #
>   # Smtp delivery local policy
> @@ -778,6 +780,12 @@ optional_policy(`
>   ')
>   
>   optional_policy(`
> +	dbus_send_system_bus(postfix_smtp_t)
> +	dbus_system_bus_client(postfix_smtp_t)
> +	init_dbus_chat(postfix_smtp_t)
> +')
> +
> +optional_policy(`
>   	dovecot_stream_connect(postfix_smtp_t)
>   ')
>   
> @@ -815,9 +823,8 @@ optional_policy(`
>   ')
>   
>   optional_policy(`
> -	dbus_send_system_bus(postfix_smtp_t)
> -	dbus_system_bus_client(postfix_smtp_t)
> -	init_dbus_chat(postfix_smtp_t)
> +	dbus_system_bus_client(postfix_smtpd_t)
> +	init_dbus_chat(postfix_smtpd_t)
>   ')
>   
>   optional_policy(`

Please use systemd_use_nss() instead of the individual dbus and init rules.

-- 
Chris PeBenito