Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Fri, 18 Feb 2022 02:13:55 +1100
From:   Russell Coker <russell@coker.com.au>
To:     Daniel Burgener <dburgener@linux.microsoft.com>,
        selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] rasdaemon V2
User-Agent: K-9 Mail for Android
In-Reply-To: <e80b4363-6d18-3866-630a-961525fcfe47@linux.microsoft.com>
References: <Yg5fx37xkpo1WVX6@xev.coker.com.au> <e80b4363-6d18-3866-630a-961525fcfe47@linux.microsoft.com>
Message-ID: <B1BD91EA-BA17-4AFA-8014-6F50A2181229@coker.com.au>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Thanks=2E I'll send another patch based on that in about 12 hours=2E

On 18 February 2022 1:54:19 am AEDT, Daniel Burgener <dburgener@linux=2Emi=
crosoft=2Ecom> wrote:
>On 2/17/2022 9:46 AM, Russell Coker wrote:
>> Same as before but with the needed summary and removed the obsolete loc=
kdown
>> rule=2E
>>=20
>> Should be ready for merging now=2E
>> Signed-off-by: Russell Coker <russell@coker=2Ecom=2Eau>
>
>I thought this sounded familiar, so I searched my inbox, and it looks
>like you submitted this same patch a year ago, and there was feedback
>from Chris and Dominick that doesn't seem to be addressed yet=2E  I'll
>try to capture it all inline below=2E
>
>>=20
>> Index: refpolicy-2=2E20220217/policy/modules/kernel/filesystem=2Eif
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- refpolicy-2=2E20220217=2Eorig/policy/modules/kernel/filesystem=2Eif
>> +++ refpolicy-2=2E20220217/policy/modules/kernel/filesystem=2Eif
>> @@ -5485,6 +5485,43 @@ interface(`fs_getattr_tracefs_files',`
>>  =20
>>   ########################################
>>   ## <summary>
>> +##	Read/write trace filesystem files
>> +## </summary>
>> +## <param name=3D"domain">
>> +##      <summary>
>> +##      Domain allowed access=2E
>> +##      </summary>
>> +## </param>
>> +#
>> +interface(`fs_write_tracefs_files',`
>> +	gen_require(`
>> +		type tracefs_t;
>> +	')
>> +
>> +	allow $1 tracefs_t:dir list_dir_perms;
>> +	allow $1 tracefs_t:file rw_file_perms;
>> +')
>> +
>> +########################################
>> +## <summary>
>> +##	create trace filesystem directories
>> +## </summary>
>> +## <param name=3D"domain">
>> +##      <summary>
>> +##      Domain allowed access=2E
>> +##      </summary>
>> +## </param>
>> +#
>> +interface(`fs_create_tracefs_dirs',`
>> +	gen_require(`
>> +		type tracefs_t;
>> +	')
>> +
>> +	allow $1 tracefs_t:dir { create rw_dir_perms };
>> +')
>> +
>> +########################################
>> +## <summary>
>>   ##	Mount a XENFS filesystem=2E
>>   ## </summary>
>>   ## <param name=3D"domain">
>> Index: refpolicy-2=2E20220217/policy/modules/services/rasdaemon=2Efc
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- /dev/null
>> +++ refpolicy-2=2E20220217/policy/modules/services/rasdaemon=2Efc
>> @@ -0,0 +1,3 @@
>> +/usr/sbin/rasdaemon			--	gen_context(system_u:object_r:rasdaemon_exec_=
t,s0)
>> +/var/lib/rasdaemon(/=2E*)?			gen_context(system_u:object_r:rasdaemon_v=
ar_t,s0)
>> +
>> Index: refpolicy-2=2E20220217/policy/modules/services/rasdaemon=2Eif
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- /dev/null
>> +++ refpolicy-2=2E20220217/policy/modules/services/rasdaemon=2Eif
>> @@ -0,0 +1 @@
>> +## <summary>RAS (Reliability, Availability and Serviceability) logging=
 tool</summary>
>> Index: refpolicy-2=2E20220217/policy/modules/services/rasdaemon=2Ete
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- /dev/null
>> +++ refpolicy-2=2E20220217/policy/modules/services/rasdaemon=2Ete
>> @@ -0,0 +1,47 @@
>> +policy_module(rasdaemon, 1=2E0=2E0)
>> +
>> +# rasdaemon is a RAS (Reliability, Availability and Serviceability) lo=
gging
>> +# tool=2E  It currently records memory errors, using the EDAC tracing =
events=2E
>> +# EDAC are drivers in the Linux kernel that handle detection of ECC er=
rors
>> +# from memory controllers for most chipsets on x86 and ARM architectur=
es=2E
>> +#
>> +# https://git=2Einfradead=2Eorg/users/mchehab/rasdaemon=2Egit
>
>This can get wrapped in xml <summary> and <desc> tags so it gets put in=
=20
>docs=2E
>
>> +
>> +########################################
>> +#
>> +# Declarations
>> +#
>> +
>> +type rasdaemon_t;
>> +type rasdaemon_exec_t;
>> +init_daemon_domain(rasdaemon_t, rasdaemon_exec_t)
>> +
>> +type rasdaemon_var_t;
>> +files_type(rasdaemon_var_t)
>> +
>> +########################################
>> +#
>> +# Local policy
>> +#
>> +
>> +allow rasdaemon_t self:unix_dgram_socket create_socket_perms;
>
>This is redundant, implied by logging_send_syslog_message()
>
>> +
>> +allow rasdaemon_t rasdaemon_var_t:dir manage_dir_perms;
>> +allow rasdaemon_t rasdaemon_var_t:file manage_file_perms;
>> +
>> +kernel_read_debugfs(rasdaemon_t)
>> +kernel_read_system_state(rasdaemon_t)
>> +kernel_read_vm_overcommit_sysctl(rasdaemon_t)
>> +kernel_search_fs_sysctls(rasdaemon_t)
>> +
>> +dev_list_sysfs(rasdaemon_t)
>> +dev_read_urand(rasdaemon_t)
>> +
>> +files_read_etc_symlinks(rasdaemon_t)
>
>This is redundant (implied by miscfiles_read_localization)
>
>> +files_search_var_lib(rasdaemon_t)
>> +fs_write_tracefs_files(rasdaemon_t)
>> +fs_create_tracefs_dirs(rasdaemon_t)
>> +
>> +logging_send_syslog_msg(rasdaemon_t)
>> +miscfiles_read_localization(rasdaemon_t)
>> +
>

--=20
Sent from my Huawei Mate 9 with K-9 Mail=2E