Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Russell Coker <russell@coker.com.au>
To:     Chris PeBenito <pebenito@ieee.org>
Reply-To: russell@coker.com.au
Cc:     selinux-refpolicy@vger.kernel.org
Subject: Re: [PATCH] rasdaemon (replacement for mcelog)
Date:   Fri, 18 Feb 2022 11:25:55 +1100
Message-ID: <18698496.iPHH8zDuP6@xev>
In-Reply-To: <cd3be651-38de-9998-7dc6-2c6f0f20277e@ieee.org>
References: <YEWNyIsSThUoVAsc@xev> <ypjl35x6ja14.fsf@defensec.nl> <cd3be651-38de-9998-7dc6-2c6f0f20277e@ieee.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Precedence: bulk

On Saturday, 13 March 2021 02:03:48 AEDT Chris PeBenito wrote:
> On 3/8/21 3:59 AM, Dominick Grift wrote:
> > Dominick Grift <dominick.grift@defensec.nl> writes:
> >> Russell Coker <russell@coker.com.au> writes:
> >>> This is policy for rasdaemon, the new replacement for mcelog.  The
> >>> /dev/mcelog device is now an obsolete kernel feature that can be enabled
> >>> for backward compatibility and rasdaeon with tracefs is the new way.
> >>> 
> >>> I've tested this and it seems to work OK, but all my servers are working
> >>> well so I haven't been able to test the case of actually detecting an
> >>> error.  It would be good if someone with a known damaged server could
> >>> give
> >>> it a go.
> >>> 
> >>> I think this is ready for merging.
> >>> 
> >>> Signed-off-by: Russell Coker <russell@coker.com.au>
> 
> [...]
> 
> >>> +++ refpolicy-2.20210203/policy/modules/services/rasdaemon.te
> >>> @@ -0,0 +1,49 @@
> >>> +policy_module(rasdaemon, 1.0.0)
> >>> +
> >>> +# rasdaemon is a RAS (Reliability, Availability and Serviceability)
> >>> logging +# tool.  It currently records memory errors, using the EDAC
> >>> tracing events. +# EDAC are drivers in the Linux kernel that handle
> >>> detection of ECC errors +# from memory controllers for most chipsets on
> >>> x86 and ARM architectures. +#
> >>> +# https://git.infradead.org/users/mchehab/rasdaemon.git
> >> 
> >> Please use the <summary></summary> for description. We have an api
> >> browser (make doc) and the description should end up there as well.
> >> 
> >> <summary>Reliability, Availability and Serviceability (RAS) logging
> >> tool.</summary>
> >> 
> >> I would omit the url because those are often subject to change anyway.
> 
> I agree if we have this amount of description it should go in the XML, but
> the module level actually has a <desc> tag that goes after <summary>.  I
> like Dominick's summary, but the Russel's comment can go in the module
> <desc>.
> 
> The URL can remain.  Yes, it can change, but at least there are some
> breadcrumbs if this program becomes obsolete or unmaintained.

So you mean having the following in rasdaemon.if ?

## <summary>RAS (Reliability, Availability and Serviceability) logging tool</
summary>
##
## <desc>
## rasdaemon is a RAS (Reliability, Availability and Serviceability) logging
## tool.  It currently records memory errors, using the EDAC tracing events.
## EDAC are drivers in the Linux kernel that handle detection of ECC errors
## from memory controllers for most chipsets on x86 and ARM architectures.
##
## https://git.infradead.org/users/mchehab/rasdaemon.git
## </desc>

-- 
My Main Blog         http://etbe.coker.com.au/
My Documents Blog    http://doc.coker.com.au/