Received-SPF: pass (google.com: domain of selinux-refpolicy-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <9629e26a-381b-5482-1493-ac3387616507@ieee.org>
Date:   Mon, 2 Oct 2023 08:40:50 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: append_lnk_files_pattern
To:     Russell Coker <russell@coker.com.au>,
        selinux-refpolicy@vger.kernel.org
References: <4932293.0VBMTVartN@cupcakke>
Content-Language: en-US
From:   Chris PeBenito <pebenito@ieee.org>
In-Reply-To: <4932293.0VBMTVartN@cupcakke>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 9/30/2023 7:55 AM, Russell Coker wrote:
> Why do we have the pattern append_lnk_files_pattern?  It's not used anywhere
> in refpolicy along with write_lnk_files_pattern.  The sesearch command shows
> only the following uses of append permission for lnk_file.

More than likely it's simply a copy-paste when I first generated the macros.


> # sesearch -A -c lnk_file -p append
> allow files_unconfined_type file_type:lnk_file { append create execmod execute
> getattr ioctl link lock map mounton open quotaon read relabelfrom relabelto
> rename setattr unlink watch write };
> allow filesystem_unconfined_type filesystem_type:lnk_file { append create
> execmod execute getattr ioctl link lock map mounton open quotaon read
> relabelfrom relabelto rename setattr unlink watch write };
> allow kern_unconfined proc_type:lnk_file { append create execmod execute
> getattr ioctl link lock map mounton open quotaon read relabelfrom relabelto
> rename setattr unlink watch write };
> allow kern_unconfined unlabeled_t:lnk_file { append create execmod execute
> getattr ioctl link lock map mounton open quotaon read relabelfrom relabelto
> rename setattr unlink watch write };
> 
> I guess that the kern_unconfined stuff is related to the magic symlinks in /
> proc/PID directories.  Is there any other way where a symlink can be appended?
> 
> Does it make sense to have the append macros and the write macros with append
> permission included?

The way I see it (and how the various perm macros are designed), if a 
rule has write, then append is also implied.  Append may not make sense 
for lnk_file, but I don't see a downside to having it.


-- 
Chris PeBenito