2008-03-31 19:01:58

by Jeff Layton

Subject: [PATCH] NFS: initialize flags field in nfs_open_context

The nfs_open_context struct had a "flags" field added recently, but the
allocator isn't initializing it. It also looks like the allocator isn't
initializing the mode or list either, but they seem to be overwritten
by the caller, so that's less of an issue.

Signed-off-by: Jeff Layton <[email protected]>
---
fs/nfs/inode.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index a4c7cf2..6f88d7c 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -506,6 +506,7 @@ static struct nfs_open_context *alloc_nfs_open_context(struct vfsmount *mnt, str
ctx->cred = get_rpccred(cred);
ctx->state = NULL;
ctx->lockowner = current->files;
+ ctx->flags = 0;
ctx->error = 0;
ctx->dir_cookie = 0;
atomic_set(&ctx->count, 1);
--
1.5.3.6

2008-03-31 22:12:13

by Myklebust, Trond

Subject: Re: [PATCH] NFS: initialize flags field in nfs_open_context

On Mon, 2008-03-31 at 15:01 -0400, Jeff Layton wrote:
> The nfs_open_context struct had a "flags" field added recently, but the
> allocator isn't initializing it. It also looks like the allocator isn't
> initializing the mode or list either, but they seem to be overwritten
> by the caller, so that's less of an issue.
>
> Signed-off-by: Jeff Layton <[email protected]>

Thanks Jeff!

--
Trond Myklebust
Linux NFS client maintainer

NetApp
[email protected]
http://www.netapp.com