2008-04-30 16:48:08

by Eric Paris

[permalink] [raw]
Subject: Re: [PATCH] NFS/LSM: Make NFSv4 set LSM mount options

On Fri, 2008-04-18 at 09:12 +1000, James Morris wrote:
> On Thu, 17 Apr 2008, Eric Paris wrote:
>
> > NFSv3 get_sb operations call into the LSM layer to set security options
> > passed from userspace. NFSv4 hooks were not originally added since it
> > was reasonably late in the merge window and NFSv3 was the only thing
> > that had regressed (v4 has never supported any LSM options)
> >
> > This patch makes NFSv4 call into the LSM to set security options rather
> > than just blindly dropping them with no notice to the user as happens
> > today. This patch was tested in a simple NFSv4 environment with the
> > context= option and appeared to work as expected.
> >
> > Signed-off-by: Eric Paris <[email protected]>
>
> Acked-by: James Morris <[email protected]>

Would any of the NFS people please ack and push this patch to linus? I
don't want to ship 2.6.26 with NFSv4 continuing to just silently drop
LSM mount options.

Thanks
-Eric