2008-05-08 04:17:08

by NeilBrown

Subject: [PATCH nfs-utils] Give useful error if mount.nfs not installed setuid.

If mount.nfs is not installed setuid, an attempt to perform a "user"
or "users" mount will fail with a fairly obscure error message,
typically about getting "permission denied" from the server.

This patch gives a more helpful message in that case.

Signed-off-by: NeilBrown <[email protected]>

diff --git a/utils/mount/mount.c b/utils/mount/mount.c
index 5076468..57360fb 100644
--- a/utils/mount/mount.c
+++ b/utils/mount/mount.c
@@ -539,6 +539,12 @@ int main(int argc, char *argv[])
mnt_err = EX_USAGE;
goto out;
}
+
+ if (geteuid() != 0) {
+ nfs_error(_("%s: not installed setuid - "
+ "\"user\" NFS mounts not supported."));
+ exit(EX_FAIL);
+ }
}

if (chk_mountpoint(mount_point)) {

2008-05-08 09:26:25

by Steve Dickson

Subject: Re: [PATCH nfs-utils] Give useful error if mount.nfs not installed setuid.

Neil Brown wrote:
> If mount.nfs is not installed setuid, an attempt to perform a "user"
> or "users" mount will fail with a fairly obscure error message,
> typically about getting "permission denied" from the server.
>
> This patch gives a more helpful message in that case.
>
> Signed-off-by: NeilBrown <[email protected]>
Committed... thanks...

steved.