2007-12-20 19:55:12

by Chuck Lever III

[permalink] [raw]
Subject: [PATCH 6/8] NFS: nfs_write_end clean up

Clean up: commit 4899f9c8 added nfs_write_end(), which introduces a
conditional expression that returns an unsigned integer in one arm and
a signed integer in the other.

Signed-off-by: Chuck Lever <[email protected]>
---

fs/nfs/file.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index b3bb89f..6ec5fbf 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -349,7 +349,9 @@ static int nfs_write_end(struct file *file, struct address_space *mapping,
unlock_page(page);
page_cache_release(page);

- return status < 0 ? status : copied;
+ if (status < 0)
+ return status;
+ return copied;
}

static void nfs_invalidate_page(struct page *page, unsigned long offset)