2020-03-19 15:31:57

by J. Bruce Fields

Subject: [PATCH] nfsd: fsnotify on rmdir under nfsd/clients/

From: "J. Bruce Fields" <[email protected]>

Userspace should be able to monitor nfsd/clients/ to see when clients
come and go, but we're failing to send fsnotify events.

Cc: [email protected]
Signed-off-by: J. Bruce Fields <[email protected]>
---
fs/nfsd/nfsctl.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
index e109a1007704..3bb2db947d29 100644
--- a/fs/nfsd/nfsctl.c
+++ b/fs/nfsd/nfsctl.c
@@ -1333,6 +1333,7 @@ void nfsd_client_rmdir(struct dentry *dentry)
dget(dentry);
ret = simple_rmdir(dir, dentry);
WARN_ON_ONCE(ret);
+ fsnotify_rmdir(dir, dentry);
d_delete(dentry);
inode_unlock(dir);
}
--
2.25.1

2020-03-19 15:37:27

by Chuck Lever

Subject: Re: [PATCH] nfsd: fsnotify on rmdir under nfsd/clients/

> On Mar 19, 2020, at 11:30 AM, [email protected] wrote:
>
> From: "J. Bruce Fields" <[email protected]>
>
> Userspace should be able to monitor nfsd/clients/ to see when clients
> come and go, but we're failing to send fsnotify events.
>
> Cc: [email protected]
> Signed-off-by: J. Bruce Fields <[email protected]>

Applied to nfsd-5.7, thanks!


> ---
> fs/nfsd/nfsctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index e109a1007704..3bb2db947d29 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -1333,6 +1333,7 @@ void nfsd_client_rmdir(struct dentry *dentry)
> dget(dentry);
> ret = simple_rmdir(dir, dentry);
> WARN_ON_ONCE(ret);
> + fsnotify_rmdir(dir, dentry);
> d_delete(dentry);
> inode_unlock(dir);
> }
> --
> 2.25.1
>

--
Chuck Lever