2021-03-09 16:43:37

by Olga Kornievskaia

[permalink] [raw]
Subject: [PATCH v2 1/1] NFSD: fix error handling in NFSv4.0 callbacks

When the server tries to do a callback and a client fails it due to
authentication problems, we need the server to set callback down
flag in RENEW so that client can recover.

Suggested-by: Bruce Fields <[email protected]>
Signed-off-by: Olga Kornievskaia <[email protected]>
---
fs/nfsd/nfs4callback.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
index 052be5bf9ef5..f436d2ca5223 100644
--- a/fs/nfsd/nfs4callback.c
+++ b/fs/nfsd/nfs4callback.c
@@ -1186,11 +1186,8 @@ static void nfsd4_cb_done(struct rpc_task *task, void *calldata)
rpc_restart_call_prepare(task);
return;
case 1:
- switch (task->tk_status) {
- case -EIO:
- case -ETIMEDOUT:
+ if (task->tk_status)
nfsd4_mark_cb_down(clp, task->tk_status);
- }
break;
default:
BUG();
--
2.27.0