2022-06-16 20:30:27

by Steve Dickson

Subject: [PATCH 1/4] Makefile: Added the creation of config.guess and config.sub

Signed-off-by: Steve Dickson <[email protected]>
---
.gitignore | 2 ++
Makefile | 3 +++
2 files changed, 5 insertions(+)

diff --git a/.gitignore b/.gitignore
index df58159..72bdb22 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,6 +6,8 @@
aclocal.m4
autom4te.cache/
config.log
+config.guess
+config.sub
config.status
configure
include/builddefs
diff --git a/Makefile b/Makefile
index 5302e11..be7454d 100644
--- a/Makefile
+++ b/Makefile
@@ -60,6 +60,7 @@ clean: # if configure hasn't run, nothing to clean
endif

$(CONFIGURE): aclocal.m4
+ autoreconf --install
autoconf
./configure \
--prefix=/ \
@@ -96,3 +97,5 @@ install-lib: default
realclean distclean: clean
rm -f $(LDIRT) $(CONFIGURE)
rm -rf autom4te.cache Logs
+ rm -rf config.guess config.sub configure~
+
--
2.36.1

2022-06-16 20:31:17

by Steve Dickson

Subject: [PATCH 2/4] configure.ac: Removed a number warnings

Signed-off-by: Steve Dickson <[email protected]>
---
Makefile | 4 ++--
configure.ac | 8 ++++----
include/builddefs.in | 1 +
3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/Makefile b/Makefile
index be7454d..a460e78 100644
--- a/Makefile
+++ b/Makefile
@@ -60,8 +60,8 @@ clean: # if configure hasn't run, nothing to clean
endif

$(CONFIGURE): aclocal.m4
+ autoupdate --force
autoreconf --install
- autoconf
./configure \
--prefix=/ \
--exec-prefix=/ \
@@ -96,6 +96,6 @@ install-lib: default

realclean distclean: clean
rm -f $(LDIRT) $(CONFIGURE)
- rm -rf autom4te.cache Logs
+ rm -rf autom4te.cache Logs configure.ac~
rm -rf config.guess config.sub configure~

diff --git a/configure.ac b/configure.ac
index c624295..3337575 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
-AC_INIT([nfs4-acl-tools], [0.3.3])
-AC_CONFIG_HEADER(include/config.h)
+AC_INIT([nfs4-acl-tools],[0.3.3])
+AC_CONFIG_HEADERS(include/config.h)
AC_PREFIX_DEFAULT(/usr/local)

AC_CONFIG_MACRO_DIRS([m4])
@@ -12,7 +12,6 @@ AC_SUBST(enable_shared)
AC_PROG_INSTALL
AC_PROG_CC

-AC_HEADER_STDC
AC_CHECK_HEADERS([netinet/in.h stdlib.h string.h unistd.h])
AC_CHECK_HEADERS([attr/xattr.h sys/xattr.h])

@@ -33,4 +32,5 @@ AC_PACKAGE_UTILITIES([nfs4acl])
AC_PACKAGE_NEED_GETXATTR_LIBATTR
AC_MANUAL_FORMAT

-AC_OUTPUT(include/builddefs)
+AC_CONFIG_FILES([include/builddefs])
+AC_OUTPUT
diff --git a/include/builddefs.in b/include/builddefs.in
index fe49b08..3dab1de 100644
--- a/include/builddefs.in
+++ b/include/builddefs.in
@@ -43,6 +43,7 @@ LIBNFS4ACL = $(TOPDIR)/libnfs4acl/libnfs4acl.la
LIBATTR = @libattr@

prefix = @prefix@
+datarootdir = @datarootdir@
exec_prefix = @exec_prefix@

DESTDIR =
--
2.36.1

2022-06-16 20:31:17

by Steve Dickson

Subject: [PATCH 3/4] nfs4_print_ace_verbose: Removed a differ in signedness warning

Signed-off-by: Steve Dickson <[email protected]>
---
libnfs4acl/nfs4_print_ace_verbose.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libnfs4acl/nfs4_print_ace_verbose.c b/libnfs4acl/nfs4_print_ace_verbose.c
index 96a6573..ef87e89 100644
--- a/libnfs4acl/nfs4_print_ace_verbose.c
+++ b/libnfs4acl/nfs4_print_ace_verbose.c
@@ -64,7 +64,7 @@ int nfs4_print_ace_verbose(struct nfs4_ace * ace, u32 is_dir)
char * whotype_s;
char * type_s;
u32 flag;
- u32 whotype;
+ int whotype;
u32 mask;


--
2.36.1

2022-06-21 13:17:34

by Steve Dickson

Subject: Re: [PATCH 1/4] Makefile: Added the creation of config.guess and config.sub

all 4 patches committed...

On 6/16/22 4:28 PM, Steve Dickson wrote:
> Signed-off-by: Steve Dickson <[email protected]>
> ---
> .gitignore | 2 ++
> Makefile | 3 +++
> 2 files changed, 5 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index df58159..72bdb22 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -6,6 +6,8 @@
> aclocal.m4
> autom4te.cache/
> config.log
> +config.guess
> +config.sub
> config.status
> configure
> include/builddefs
> diff --git a/Makefile b/Makefile
> index 5302e11..be7454d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -60,6 +60,7 @@ clean: # if configure hasn't run, nothing to clean
> endif
>
> $(CONFIGURE): aclocal.m4
> + autoreconf --install
> autoconf
> ./configure \
> --prefix=/ \
> @@ -96,3 +97,5 @@ install-lib: default
> realclean distclean: clean
> rm -f $(LDIRT) $(CONFIGURE)
> rm -rf autom4te.cache Logs
> + rm -rf config.guess config.sub configure~
> +