2008-04-08 21:02:37

by Chuck Lever III

[permalink] [raw]
Subject: Re: [PATCH] SUNRPC: RPC client's TCP transport ignores errors during connect

On Apr 8, 2008, at 4:21 PM, Trond Myklebust wrote:
> On Tue, 2008-04-08 at 15:35 -0400, Chuck Lever wrote:
>> Last week, you claimed:
>>
>>> The client currently doesn't retry in the case of a connection
>>> failing for a soft RPC request.
>>
>> In fact, it does retry a connection attempt on soft RPC requests
>> until a *major* timeout occurs.
>
> You're right. I forgot that we changed that.
>
>> So is the actual bug in call_timeout?
>
> I'm confused. What should call_timeout be doing differently?

If the current soft connect retry behavior is what is desired (and
thinking on it, it is safer than failing the requests outright) then
I agree there is no bug.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com