The getaddrinfo problem needs a proper fix and probably a
consideration of similar patterns elsewhere in the code.
The others are relatively straightforward and are more suitable for use as-is.
A fix not included would be to avoid using "-Werror" except when
developing-- or at least make its use optional. Without knowledge of
the compilers used by downstream, this option may cause builds to fail
for unimportant reasons (and even if it works with all compilers
today, it might not tomorrow...). Would be nice to have that in
before the next tagged release :). GCC 7.3.0 seems to be unhappy with
some prototypes for example, I don't have them handy but can send them
along if that'd be useful.
Thanks! LMK if you have any questions or concerns, hopefully these are helpful.
~Will
On 04/29/2018 07:16 PM, Will Dietz wrote:
> The getaddrinfo problem needs a proper fix and probably a
> consideration of similar patterns elsewhere in the code.
>
> The others are relatively straightforward and are more suitable for use as-is.
>
> A fix not included would be to avoid using "-Werror" except when
> developing-- or at least make its use optional. Without knowledge of
> the compilers used by downstream, this option may cause builds to fail
> for unimportant reasons (and even if it works with all compilers
> today, it might not tomorrow...). Would be nice to have that in
> before the next tagged release :). GCC 7.3.0 seems to be unhappy with
> some prototypes for example, I don't have them handy but can send them
> along if that'd be useful.
>
> Thanks! LMK if you have any questions or concerns, hopefully these are helpful.
Having the patch attached like this makes it very different to review
and comment on... It much better when patches are posted in a thread.
Could you please repost these patch in a thread format...
Here is the command I use:
DRYRUN=--dry-run
DIR=/tmp
git send-email $DRYRUN --suppress-cc=all --suppress-from --no-chain-reply-to \
--from "My Name <[email protected]>" \
--to "Linux NFS Mailing list <[email protected]>" \
--smtp-server smtp.com $DIR/*.patch
tia,
steved