2008-02-05 01:56:41

by Chuck Lever III

[permalink] [raw]
Subject: Re: [PATCH 4/5] NFSD: Remove NFSD_TCP kernel build option

On Feb 4, 2008, at 7:29 PM, Greg Banks wrote:
> Trond Myklebust wrote:
>> On Tue, 2008-02-05 at 11:19 +1100, Greg Banks wrote:
>>
>>> Chuck Lever wrote:
>>>
>>>> TCP support in the Linux NFS server is stable enough that we can
>>>> leave it
>>>> on always. CONFIG_NFSD_TCP adds about 10 lines of code, and
>>>> defaults to
>>>> "Y" anyway.
>>>>
>>>> A run-time switch might be more appropriate if people feel they
>>>> would like
>>>> to disable NFSD's TCP support.
>>>>
>>>>
>>>>
>>> Looks good.
>>>
>>> Actually, I'd be inclined to go one step further and set UDP support
>>> off by default.
>>>
>>
>> That will break older clients.
>>
>>
> Hence the default, rather than removing the code entirely.


What might make sense is to remove NFSD_TCP, but add NFSD_UDP,
defaulting to Y.

Then in a year or two we can change the default to N.

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com


2008-02-05 05:43:12

by Greg Banks

[permalink] [raw]
Subject: Re: [PATCH 4/5] NFSD: Remove NFSD_TCP kernel build option

Chuck Lever wrote:
> On Feb 4, 2008, at 7:29 PM, Greg Banks wrote:
>> Trond Myklebust wrote:
>>> On Tue, 2008-02-05 at 11:19 +1100, Greg Banks wrote:
>>>
>>>> Chuck Lever wrote:
>>>>
>>>>> TCP support in the Linux NFS server is stable enough that we can
>>>>> leave it
>>>>> on always. CONFIG_NFSD_TCP adds about 10 lines of code, and
>>>>> defaults to
>>>>> "Y" anyway.
>>>>>
>>>>> A run-time switch might be more appropriate if people feel they
>>>>> would like
>>>>> to disable NFSD's TCP support.
>>>>>
>>>>>
>>>>>
>>>> Looks good.
>>>>
>>>> Actually, I'd be inclined to go one step further and set UDP support
>>>> off by default.
>>>>
>>>
>>> That will break older clients.
>>>
>>>
>> Hence the default, rather than removing the code entirely.
>
>
> What might make sense is to remove NFSD_TCP, but add NFSD_UDP,
> defaulting to Y.
>
> Then in a year or two we can change the default to N.
>
Fine by me.


--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
The cake is *not* a lie.
I don't speak for SGI.