2012-02-21 07:28:20

by Dan Carpenter

Subject: [patch] svcrdma: silence a Sparse warning

Sparse complains that the definition function definition and the
implementation aren't anotated the same way.

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
index d205e9f..0b8e3e6 100644
--- a/include/linux/sunrpc/svc_rdma.h
+++ b/include/linux/sunrpc/svc_rdma.h
@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
- u32, u64, u32);
+ __be32, __be64, u32);
extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
struct rpcrdma_msg *,
struct rpcrdma_msg *,

2012-02-21 21:23:25

by J. Bruce Fields

Subject: Re: [patch] svcrdma: silence a Sparse warning

On Tue, Feb 21, 2012 at 03:08:49PM -0600, Tom Tucker wrote:
>
> This is my bad. I don't know why my sparse didn't catch it, it seems
> like it should have. Thanks for
> fixing it Dan.

Thanks, applying.--b.

>
> Tom
>
>
> On 2/21/12 3:06 PM, J. Bruce Fields wrote:
> >(Cc'ing Tom).
> >
> >On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
> >>Sparse complains that the definition function definition and the
> >>implementation aren't anotated the same way.
> >>
> >>Signed-off-by: Dan Carpenter<[email protected]>
> >>
> >>diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> >>index d205e9f..0b8e3e6 100644
> >>--- a/include/linux/sunrpc/svc_rdma.h
> >>+++ b/include/linux/sunrpc/svc_rdma.h
> >>@@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
> >> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
> >> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
> >> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
> >>- u32, u64, u32);
> >>+ __be32, __be64, u32);
> >> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
> >> struct rpcrdma_msg *,
> >> struct rpcrdma_msg *,
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >the body of a message to [email protected]
> >More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

2012-02-21 21:06:07

by J. Bruce Fields

Subject: Re: [patch] svcrdma: silence a Sparse warning

(Cc'ing Tom).

On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
> Sparse complains that the definition function definition and the
> implementation aren't anotated the same way.
>
> Signed-off-by: Dan Carpenter <[email protected]>
>
> diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> index d205e9f..0b8e3e6 100644
> --- a/include/linux/sunrpc/svc_rdma.h
> +++ b/include/linux/sunrpc/svc_rdma.h
> @@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
> - u32, u64, u32);
> + __be32, __be64, u32);
> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
> struct rpcrdma_msg *,
> struct rpcrdma_msg *,

2012-02-21 21:08:49

by Tom Tucker

Subject: Re: [patch] svcrdma: silence a Sparse warning

This is my bad. I don't know why my sparse didn't catch it, it seems like
it should have. Thanks for
fixing it Dan.

Tom


On 2/21/12 3:06 PM, J. Bruce Fields wrote:
> (Cc'ing Tom).
>
> On Tue, Feb 21, 2012 at 10:28:04AM +0300, Dan Carpenter wrote:
>> Sparse complains that the definition function definition and the
>> implementation aren't anotated the same way.
>>
>> Signed-off-by: Dan Carpenter<[email protected]>
>>
>> diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
>> index d205e9f..0b8e3e6 100644
>> --- a/include/linux/sunrpc/svc_rdma.h
>> +++ b/include/linux/sunrpc/svc_rdma.h
>> @@ -190,7 +190,7 @@ extern int svc_rdma_xdr_encode_error(struct svcxprt_rdma *,
>> extern void svc_rdma_xdr_encode_write_list(struct rpcrdma_msg *, int);
>> extern void svc_rdma_xdr_encode_reply_array(struct rpcrdma_write_array *, int);
>> extern void svc_rdma_xdr_encode_array_chunk(struct rpcrdma_write_array *, int,
>> - u32, u64, u32);
>> + __be32, __be64, u32);
>> extern void svc_rdma_xdr_encode_reply_header(struct svcxprt_rdma *,
>> struct rpcrdma_msg *,
>> struct rpcrdma_msg *,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html