2013-10-21 09:04:11

by Mkrtchyan, Tigran

[permalink] [raw]
Subject: [PATCH] mountstats: enforce new python syntax

$ mountstats
File "/usr/sbin/mountstats", line 272
(count, ((count * 100) / sends)), end=' ')
^
SyntaxError: invalid syntax

Signed-off-by: Tigran Mkrtchyan <[email protected]>
---
tools/mountstats/mountstats.py | 1 +
1 file changed, 1 insertion(+)

diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
index 3f5fea5..351145e 100644
--- a/tools/mountstats/mountstats.py
+++ b/tools/mountstats/mountstats.py
@@ -1,5 +1,6 @@
#!/usr/bin/env python
# -*- python-mode -*-
+from __future__ import print_function
"""Parse /proc/self/mountstats and display it in human readable form
"""

--
1.8.3.1



2013-10-21 14:18:59

by Steve Dickson

[permalink] [raw]
Subject: Re: [PATCH] mountstats: enforce new python syntax



On 21/10/13 10:04, Weston Andros Adamson wrote:
> I posted a similar patch last week.
Which has been committed!

steved.
>
> -dros
>
> On Oct 21, 2013, at 5:04 AM, Tigran Mkrtchyan <[email protected]> wrote:
>
>> $ mountstats
>> File "/usr/sbin/mountstats", line 272
>> (count, ((count * 100) / sends)), end=' ')
>> ^
>> SyntaxError: invalid syntax
>>
>> Signed-off-by: Tigran Mkrtchyan <[email protected]>
>> ---
>> tools/mountstats/mountstats.py | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
>> index 3f5fea5..351145e 100644
>> --- a/tools/mountstats/mountstats.py
>> +++ b/tools/mountstats/mountstats.py
>> @@ -1,5 +1,6 @@
>> #!/usr/bin/env python
>> # -*- python-mode -*-
>> +from __future__ import print_function
>> """Parse /proc/self/mountstats and display it in human readable form
>> """
>>
>> --
>> 1.8.3.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

2013-10-21 14:04:26

by Weston Andros Adamson

[permalink] [raw]
Subject: Re: [PATCH] mountstats: enforce new python syntax

I posted a similar patch last week.

-dros

On Oct 21, 2013, at 5:04 AM, Tigran Mkrtchyan <[email protected]> wrote:

> $ mountstats
> File "/usr/sbin/mountstats", line 272
> (count, ((count * 100) / sends)), end=' ')
> ^
> SyntaxError: invalid syntax
>
> Signed-off-by: Tigran Mkrtchyan <[email protected]>
> ---
> tools/mountstats/mountstats.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/mountstats/mountstats.py b/tools/mountstats/mountstats.py
> index 3f5fea5..351145e 100644
> --- a/tools/mountstats/mountstats.py
> +++ b/tools/mountstats/mountstats.py
> @@ -1,5 +1,6 @@
> #!/usr/bin/env python
> # -*- python-mode -*-
> +from __future__ import print_function
> """Parse /proc/self/mountstats and display it in human readable form
> """
>
> --
> 1.8.3.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html


2013-10-21 14:25:05

by Mkrtchyan, Tigran

[permalink] [raw]
Subject: Re: [PATCH] mountstats: enforce new python syntax



----- Original Message -----
> From: "Steve Dickson" <[email protected]>
> To: "Weston Andros Adamson" <[email protected]>
> Cc: "Tigran Mkrtchyan" <[email protected]>, "<[email protected]>" <[email protected]>
> Sent: Monday, October 21, 2013 4:19:31 PM
> Subject: Re: [PATCH] mountstats: enforce new python syntax
>
>
>
> On 21/10/13 10:04, Weston Andros Adamson wrote:
> > I posted a similar patch last week.
> Which has been committed!

Ah, then sorry for the noise!

Tigran.
>
> steved.
> >
> > -dros
> >
> > On Oct 21, 2013, at 5:04 AM, Tigran Mkrtchyan <[email protected]>
> > wrote:
> >
> >> $ mountstats
> >> File "/usr/sbin/mountstats", line 272
> >> (count, ((count * 100) / sends)), end=' ')
> >> ^
> >> SyntaxError: invalid syntax
> >>
> >> Signed-off-by: Tigran Mkrtchyan <[email protected]>
> >> ---
> >> tools/mountstats/mountstats.py | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/tools/mountstats/mountstats.py
> >> b/tools/mountstats/mountstats.py
> >> index 3f5fea5..351145e 100644
> >> --- a/tools/mountstats/mountstats.py
> >> +++ b/tools/mountstats/mountstats.py
> >> @@ -1,5 +1,6 @@
> >> #!/usr/bin/env python
> >> # -*- python-mode -*-
> >> +from __future__ import print_function
> >> """Parse /proc/self/mountstats and display it in human readable form
> >> """
> >>
> >> --
> >> 1.8.3.1
> >>
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> >> the body of a message to [email protected]
> >> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to [email protected]
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>