2013-10-22 22:30:23

by Joe Perches

[permalink] [raw]
Subject: [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table

Joe Perches (24):
arm: Convert use of typedef ctl_table to struct ctl_table
ia64: Convert use of typedef ctl_table to struct ctl_table
s390: Convert use of typedef ctl_table to struct ctl_table
tile: Convert use of typedef ctl_table to struct ctl_table
cdrom: Convert use of typedef ctl_table to struct ctl_table
random: Convert use of typedef ctl_table to struct ctl_table
infiniband: Convert use of typedef ctl_table to struct ctl_table
md: Convert use of typedef ctl_table to struct ctl_table
parport: Convert use of typedef ctl_table to struct ctl_table
scsi: Convert use of typedef ctl_table to struct ctl_table
coda: Convert use of typedef ctl_table to struct ctl_table
fscache: Convert use of typedef ctl_table to struct ctl_table
lockd: Convert use of typedef ctl_table to struct ctl_table
nfs: Convert use of typedef ctl_table to struct ctl_table
inotify: Convert use of typedef ctl_table to struct ctl_table
ntfs: Convert use of typedef ctl_table to struct ctl_table
ocfs2: Convert use of typedef ctl_table to struct ctl_table
proc: Convert use of typedef ctl_table to struct ctl_table
fs: Convert use of typedef ctl_table to struct ctl_table
key: Convert use of typedef ctl_table to struct ctl_table
ipc: Convert use of typedef ctl_table to struct ctl_table
kernel: Convert use of typedef ctl_table to struct ctl_table
mm: Convert use of typedef ctl_table to struct ctl_table
security:keys: Convert use of typedef ctl_table to struct ctl_table

arch/arm/kernel/isa.c | 6 ++---
arch/ia64/kernel/crash.c | 4 +--
arch/ia64/kernel/perfmon.c | 6 ++---
arch/s390/appldata/appldata_base.c | 10 ++++----
arch/s390/kernel/debug.c | 2 +-
arch/s390/mm/cmm.c | 8 +++---
arch/tile/kernel/proc.c | 4 +--
drivers/cdrom/cdrom.c | 10 ++++----
drivers/char/random.c | 4 +--
drivers/infiniband/core/ucma.c | 2 +-
drivers/md/md.c | 6 ++---
drivers/parport/procfs.c | 52 ++++++++++++++++++--------------------
drivers/scsi/scsi_sysctl.c | 6 ++---
fs/coda/sysctl.c | 4 +--
fs/dcache.c | 2 +-
fs/drop_caches.c | 2 +-
fs/eventpoll.c | 2 +-
fs/file_table.c | 4 +--
fs/fscache/main.c | 4 +--
fs/inode.c | 2 +-
fs/lockd/svc.c | 6 ++---
fs/nfs/nfs4sysctl.c | 6 ++---
fs/nfs/sysctl.c | 6 ++---
fs/notify/inotify/inotify_user.c | 2 +-
fs/ntfs/sysctl.c | 4 +--
fs/ocfs2/stackglue.c | 8 +++---
fs/proc/proc_sysctl.c | 2 +-
include/linux/key.h | 2 +-
ipc/ipc_sysctl.c | 14 +++++-----
ipc/mq_sysctl.c | 10 ++++----
kernel/sysctl.c | 2 +-
kernel/utsname_sysctl.c | 6 ++---
mm/page-writeback.c | 2 +-
mm/page_alloc.c | 12 ++++-----
security/keys/sysctl.c | 2 +-
35 files changed, 111 insertions(+), 113 deletions(-)

--
1.8.1.2.459.gbcd45b4.dirty



2013-10-22 22:31:04

by Joe Perches

[permalink] [raw]
Subject: [PATCH 14/24] nfs: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed.

Signed-off-by: Joe Perches <[email protected]>
---
fs/nfs/nfs4sysctl.c | 6 +++---
fs/nfs/sysctl.c | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/fs/nfs/nfs4sysctl.c b/fs/nfs/nfs4sysctl.c
index 2628d92..b6ebe7e 100644
--- a/fs/nfs/nfs4sysctl.c
+++ b/fs/nfs/nfs4sysctl.c
@@ -16,7 +16,7 @@ static const int nfs_set_port_min = 0;
static const int nfs_set_port_max = 65535;
static struct ctl_table_header *nfs4_callback_sysctl_table;

-static ctl_table nfs4_cb_sysctls[] = {
+static struct ctl_table nfs4_cb_sysctls[] = {
{
.procname = "nfs_callback_tcpport",
.data = &nfs_callback_set_tcpport,
@@ -36,7 +36,7 @@ static ctl_table nfs4_cb_sysctls[] = {
{ }
};

-static ctl_table nfs4_cb_sysctl_dir[] = {
+static struct ctl_table nfs4_cb_sysctl_dir[] = {
{
.procname = "nfs",
.mode = 0555,
@@ -45,7 +45,7 @@ static ctl_table nfs4_cb_sysctl_dir[] = {
{ }
};

-static ctl_table nfs4_cb_sysctl_root[] = {
+static struct ctl_table nfs4_cb_sysctl_root[] = {
{
.procname = "fs",
.mode = 0555,
diff --git a/fs/nfs/sysctl.c b/fs/nfs/sysctl.c
index 6b3f253..bb6ed81 100644
--- a/fs/nfs/sysctl.c
+++ b/fs/nfs/sysctl.c
@@ -13,7 +13,7 @@

static struct ctl_table_header *nfs_callback_sysctl_table;

-static ctl_table nfs_cb_sysctls[] = {
+static struct ctl_table nfs_cb_sysctls[] = {
{
.procname = "nfs_mountpoint_timeout",
.data = &nfs_mountpoint_expiry_timeout,
@@ -31,7 +31,7 @@ static ctl_table nfs_cb_sysctls[] = {
{ }
};

-static ctl_table nfs_cb_sysctl_dir[] = {
+static struct ctl_table nfs_cb_sysctl_dir[] = {
{
.procname = "nfs",
.mode = 0555,
@@ -40,7 +40,7 @@ static ctl_table nfs_cb_sysctl_dir[] = {
{ }
};

-static ctl_table nfs_cb_sysctl_root[] = {
+static struct ctl_table nfs_cb_sysctl_root[] = {
{
.procname = "fs",
.mode = 0555,
--
1.8.1.2.459.gbcd45b4.dirty


2013-10-22 23:53:29

by David Daney

[permalink] [raw]
Subject: Re: [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table

On 10/22/2013 03:29 PM, Joe Perches wrote:
> Joe Perches (24):
> arm: Convert use of typedef ctl_table to struct ctl_table
> ia64: Convert use of typedef ctl_table to struct ctl_table
> s390: Convert use of typedef ctl_table to struct ctl_table
> tile: Convert use of typedef ctl_table to struct ctl_table
> cdrom: Convert use of typedef ctl_table to struct ctl_table
> random: Convert use of typedef ctl_table to struct ctl_table
> infiniband: Convert use of typedef ctl_table to struct ctl_table
> md: Convert use of typedef ctl_table to struct ctl_table
> parport: Convert use of typedef ctl_table to struct ctl_table
> scsi: Convert use of typedef ctl_table to struct ctl_table
> coda: Convert use of typedef ctl_table to struct ctl_table
> fscache: Convert use of typedef ctl_table to struct ctl_table
> lockd: Convert use of typedef ctl_table to struct ctl_table
> nfs: Convert use of typedef ctl_table to struct ctl_table
> inotify: Convert use of typedef ctl_table to struct ctl_table
> ntfs: Convert use of typedef ctl_table to struct ctl_table
> ocfs2: Convert use of typedef ctl_table to struct ctl_table
> proc: Convert use of typedef ctl_table to struct ctl_table
> fs: Convert use of typedef ctl_table to struct ctl_table
> key: Convert use of typedef ctl_table to struct ctl_table
> ipc: Convert use of typedef ctl_table to struct ctl_table
> kernel: Convert use of typedef ctl_table to struct ctl_table
> mm: Convert use of typedef ctl_table to struct ctl_table
> security:keys: Convert use of typedef ctl_table to struct ctl_table

After all this work, why not go ahead and remove the typedef? That way
people won't add more users of this abomination.

David Daney



>
> arch/arm/kernel/isa.c | 6 ++---
> arch/ia64/kernel/crash.c | 4 +--
> arch/ia64/kernel/perfmon.c | 6 ++---
> arch/s390/appldata/appldata_base.c | 10 ++++----
> arch/s390/kernel/debug.c | 2 +-
> arch/s390/mm/cmm.c | 8 +++---
> arch/tile/kernel/proc.c | 4 +--
> drivers/cdrom/cdrom.c | 10 ++++----
> drivers/char/random.c | 4 +--
> drivers/infiniband/core/ucma.c | 2 +-
> drivers/md/md.c | 6 ++---
> drivers/parport/procfs.c | 52 ++++++++++++++++++--------------------
> drivers/scsi/scsi_sysctl.c | 6 ++---
> fs/coda/sysctl.c | 4 +--
> fs/dcache.c | 2 +-
> fs/drop_caches.c | 2 +-
> fs/eventpoll.c | 2 +-
> fs/file_table.c | 4 +--
> fs/fscache/main.c | 4 +--
> fs/inode.c | 2 +-
> fs/lockd/svc.c | 6 ++---
> fs/nfs/nfs4sysctl.c | 6 ++---
> fs/nfs/sysctl.c | 6 ++---
> fs/notify/inotify/inotify_user.c | 2 +-
> fs/ntfs/sysctl.c | 4 +--
> fs/ocfs2/stackglue.c | 8 +++---
> fs/proc/proc_sysctl.c | 2 +-
> include/linux/key.h | 2 +-
> ipc/ipc_sysctl.c | 14 +++++-----
> ipc/mq_sysctl.c | 10 ++++----
> kernel/sysctl.c | 2 +-
> kernel/utsname_sysctl.c | 6 ++---
> mm/page-writeback.c | 2 +-
> mm/page_alloc.c | 12 ++++-----
> security/keys/sysctl.c | 2 +-
> 35 files changed, 111 insertions(+), 113 deletions(-)
>


2013-10-22 23:58:31

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH 00/24] treewide: Convert use of typedef ctl_table to struct ctl_table

On Tue, 2013-10-22 at 16:53 -0700, David Daney wrote:
> After all this work, why not go ahead and remove the typedef? That way
> people won't add more users of this abomination.

Hi David.

The typedef can't be removed until all the uses are gone.

I've sent this before as a single large patch as well as
individual patches.

treewide: https://lkml.org/lkml/2013/7/22/600
RemoveTypedef: https://lkml.org/lkml/2013/7/22/603


2013-10-22 22:31:43

by Joe Perches

[permalink] [raw]
Subject: [PATCH 13/24] lockd: Convert use of typedef ctl_table to struct ctl_table

This typedef is unnecessary and should just be removed.

Signed-off-by: Joe Perches <[email protected]>
---
fs/lockd/svc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 10d6c41..140cc67 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd/svc.c
@@ -435,7 +435,7 @@ EXPORT_SYMBOL_GPL(lockd_down);
* Sysctl parameters (same as module parameters, different interface).
*/

-static ctl_table nlm_sysctls[] = {
+static struct ctl_table nlm_sysctls[] = {
{
.procname = "nlm_grace_period",
.data = &nlm_grace_period,
@@ -489,7 +489,7 @@ static ctl_table nlm_sysctls[] = {
{ }
};

-static ctl_table nlm_sysctl_dir[] = {
+static struct ctl_table nlm_sysctl_dir[] = {
{
.procname = "nfs",
.mode = 0555,
@@ -498,7 +498,7 @@ static ctl_table nlm_sysctl_dir[] = {
{ }
};

-static ctl_table nlm_sysctl_root[] = {
+static struct ctl_table nlm_sysctl_root[] = {
{
.procname = "fs",
.mode = 0555,
--
1.8.1.2.459.gbcd45b4.dirty