2008-09-26 21:20:04

by J. Bruce Fields

Subject: Re: [PATCH 2/2] SUNRPC: Use short-hand IPv6 ANYADDR for RPCB_SET

On Mon, Sep 15, 2008 at 04:27:30PM -0500, Chuck Lever wrote:
> Clean up: When doing an RPCB_SET, make the kernel's rpcb client use the
> shorthand "::" for the universal form of the IPv6 ANY address.
>
> Without this patch, rpcbind will advertise:
>
> 0000:0000:0000:0000:0000:0000:0000:0000.x.y
>
> This is cosmetic only. It cleans up the display of information from
> /sbin/rpcinfo.

Also applied.

> + if (ipv6_addr_any(&address_to_register->sin6_addr))

Nit: I fixed up some initial whitespace. Checkpatch or git apply should
warn about this.

--b.

> + snprintf(buf, sizeof(buf), "::.%u.%u",
> + port >> 8, port & 0xff);
> + else
> + snprintf(buf, sizeof(buf), NIP6_FMT".%u.%u",
> + NIP6(address_to_register->sin6_addr),
> + port >> 8, port & 0xff);
> map->r_addr = buf;
>
> dprintk("RPC: %sregistering [%u, %u, %s, '%s'] with "
>

2008-09-26 21:38:00

by Chuck Lever III

Subject: Re: [PATCH 2/2] SUNRPC: Use short-hand IPv6 ANYADDR for RPCB_SET

On Sep 26, 2008, at Sep 26, 2008, 5:20 PM, J. Bruce Fields wrote:
> On Mon, Sep 15, 2008 at 04:27:30PM -0500, Chuck Lever wrote:
>> Clean up: When doing an RPCB_SET, make the kernel's rpcb client use
>> the
>> shorthand "::" for the universal form of the IPv6 ANY address.
>>
>> Without this patch, rpcbind will advertise:
>>
>> 0000:0000:0000:0000:0000:0000:0000:0000.x.y
>>
>> This is cosmetic only. It cleans up the display of information from
>> /sbin/rpcinfo.
>
> Also applied.
>
>> + if (ipv6_addr_any(&address_to_register->sin6_addr))
>
> Nit: I fixed up some initial whitespace. Checkpatch or git apply
> should
> warn about this.

Checkpatch is my usual weapon of choice, but it's not an automated
part of my workflow. I guess this one got past me.

>
>
> --b.
>
>> + snprintf(buf, sizeof(buf), "::.%u.%u",
>> + port >> 8, port & 0xff);
>> + else
>> + snprintf(buf, sizeof(buf), NIP6_FMT".%u.%u",
>> + NIP6(address_to_register->sin6_addr),
>> + port >> 8, port & 0xff);
>> map->r_addr = buf;
>>
>> dprintk("RPC: %sregistering [%u, %u, %s, '%s'] with "
>>

--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com