2010-05-31 10:12:46

by Dan Carpenter

Subject: question about gss_verify_mic_v2()

Hi Kevin,

Are we planning to add the sequencing checks later or can I remove the
comment?

net/sunrpc/auth_gss/gss_krb5_unseal.c +202 gss_verify_mic_v2()
warn: unused return: seqnum = __be64_to_cpup()

200 /* do sequencing checks */
201
202 seqnum = be64_to_cpup((__be64 *)ptr + 8);
203
204 return GSS_S_COMPLETE;
205 }

regards,
dan carpenter

2010-06-01 12:41:27

by Kevin Coffman

Subject: Re: question about gss_verify_mic_v2()

I think it would be good to add sequence checks, but I don't have the
cycles to work on it.

On Mon, May 31, 2010 at 6:12 AM, Dan Carpenter <[email protected]> wrote:
> Hi Kevin,
>
> Are we planning to add the sequencing checks later or can I remove the
> comment?
>
> net/sunrpc/auth_gss/gss_krb5_unseal.c +202 gss_verify_mic_v2()
> ? ? ? ? warn: unused return: seqnum = __be64_to_cpup()
>
> ? 200 ? ? ? ? ?/* do sequencing checks */
> ? 201
> ? 202 ? ? ? ? ?seqnum = be64_to_cpup((__be64 *)ptr + 8);
> ? 203
> ? 204 ? ? ? ? ?return GSS_S_COMPLETE;
> ? 205 ?}
>
> regards,
> dan carpenter
>
>