2022-01-28 20:40:09

by Ryusuke Konishi

[permalink] [raw]
Subject: Re: [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions

On Thu, Jan 27, 2022 at 11:47 AM NeilBrown <[email protected]> wrote:
>
> These functions are no longer useful as the only bdis that report
> congestion are in ceph, fuse, and nfs. None of those bdis can be the
> target of the calls in drbd, ext2, nilfs2, or xfs.
>
> Removing the test on bdi_write_contested() in current_may_throttle()
> could cause a small change in behaviour, but only when PF_LOCAL_THROTTLE
> is set.
>
> So replace the calls by 'false' and simplify the code - and remove the
> functions.
>
> Signed-off-by: NeilBrown <[email protected]>
> ---
> drivers/block/drbd/drbd_int.h | 3 ---
> drivers/block/drbd/drbd_req.c | 3 +--
> fs/ext2/ialloc.c | 2 --
> fs/nilfs2/segbuf.c | 11 -----------
> fs/xfs/xfs_buf.c | 3 ---
> include/linux/backing-dev.h | 26 --------------------------
> mm/vmscan.c | 4 +---
> 7 files changed, 2 insertions(+), 50 deletions(-)

for nilfs2 bits,

Acked-by: Ryusuke Konishi <[email protected]>

Thanks,
Ryusuke Konishi