2021-01-26 05:09:47

by Matthew Wilcox

Subject: Re: [PATCH 25/32] NFS: Clean up nfs_readpage() and nfs_readpages()

On Mon, Jan 25, 2021 at 09:35:49PM +0000, David Howells wrote:
> -int nfs_readpage(struct file *file, struct page *page)
> +int nfs_readpage(struct file *filp, struct page *page)

I appreciate we're inconsistent between file and filp, but we're actually
moving more towards file than filp.

2021-01-26 15:56:23

by David Wysochanski

Subject: Re: [PATCH 25/32] NFS: Clean up nfs_readpage() and nfs_readpages()

On Mon, Jan 25, 2021 at 11:01 PM Matthew Wilcox <[email protected]> wrote:
>
> On Mon, Jan 25, 2021 at 09:35:49PM +0000, David Howells wrote:
> > -int nfs_readpage(struct file *file, struct page *page)
> > +int nfs_readpage(struct file *filp, struct page *page)
>
> I appreciate we're inconsistent between file and filp, but we're actually
> moving more towards file than filp.
>
Got it, easy enough to change.