On Jun 5, 2008, at 8:08 AM, NeilBrown wrote:
> Thanks for reviewing the patch (always appreciated), but no - I don't
> want OR.
> What I really want is to eradicate all usages of
> if (strcmp(X,Y))
> in the world and make them
> if (strcmp(X,Y) != 0)
>
> Then it is clearer that it is a "!=" test.
> In this case, the condition as I had it means"
>
> If type is not nfs and type is not nfs4
> (then continue)
> which is what I want.
>
> Your version says:
> If type is not nfs or type is not nfs4
>
> and that will always be true.
>
> + if (strcmp(type, "nfs") != 0 && strcmp(type, "nfs4") !
> = 0)) {
>
>
> NeilBrown
Ahh, I did not provide much of a review since I missed your intent. :-)
Scott