2022-07-21 19:19:40

by Steve Dickson

Subject: [PATCH] rpc-pipefs-generator: allocate enough space for pipefs-directory buffer

Commit 7f8463fe fixed a warning but introduce
a regression by not allocating enough space
for the pipefs-directory buffer when it is
not the default.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2106896
Signed-off-by: Steve Dickson <[email protected]>
---
systemd/rpc-pipefs-generator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/systemd/rpc-pipefs-generator.c b/systemd/rpc-pipefs-generator.c
index 7b2bb4f7..3aaeaeaf 100644
--- a/systemd/rpc-pipefs-generator.c
+++ b/systemd/rpc-pipefs-generator.c
@@ -28,7 +28,7 @@ static int generate_mount_unit(const char *pipefs_path, const char *pipefs_unit,
{
char *path;
FILE *f;
- size_t size = (strlen(dirname) + 1 + strlen(pipefs_unit));
+ size_t size = (strlen(dirname) + 1 + strlen(pipefs_unit) + 1);

path = malloc(size);
if (!path)
--
2.36.1

2022-07-22 15:07:43

by Steve Dickson

Subject: Re: [PATCH] rpc-pipefs-generator: allocate enough space for pipefs-directory buffer

On 7/21/22 3:18 PM, Steve Dickson wrote:
> Commit 7f8463fe fixed a warning but introduce
> a regression by not allocating enough space
> for the pipefs-directory buffer when it is
> not the default.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2106896
> Signed-off-by: Steve Dickson <[email protected]>
Committed....

steved.

> ---
> systemd/rpc-pipefs-generator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/systemd/rpc-pipefs-generator.c b/systemd/rpc-pipefs-generator.c
> index 7b2bb4f7..3aaeaeaf 100644
> --- a/systemd/rpc-pipefs-generator.c
> +++ b/systemd/rpc-pipefs-generator.c
> @@ -28,7 +28,7 @@ static int generate_mount_unit(const char *pipefs_path, const char *pipefs_unit,
> {
> char *path;
> FILE *f;
> - size_t size = (strlen(dirname) + 1 + strlen(pipefs_unit));
> + size_t size = (strlen(dirname) + 1 + strlen(pipefs_unit) + 1);
>
> path = malloc(size);
> if (!path)