From: Chuck Lever Subject: Re: [RFC,PATCH 34/38] svc: Add /proc/sys/sunrpc/transport files Date: Mon, 3 Dec 2007 13:30:26 -0500 Message-ID: <1C15F1D5-88CC-4FD1-A7B9-508694A1A009@oracle.com> References: <20071129223917.14563.77633.stgit@dell3.ogc.int> <20071129224105.14563.48684.stgit@dell3.ogc.int> <20071203165853.GE16422@fieldses.org> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Cc: Tom Tucker , linux-nfs@vger.kernel.org, Neil Brown , Greg Banks To: "J. Bruce Fields" Return-path: Received: from agminet01.oracle.com ([141.146.126.228]:45311 "EHLO agminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751353AbXLCScf (ORCPT ); Mon, 3 Dec 2007 13:32:35 -0500 In-Reply-To: <20071203165853.GE16422@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Dec 3, 2007, at 11:58 AM, J. Bruce Fields wrote: > On Mon, Dec 03, 2007 at 11:44:15AM -0500, Chuck Lever wrote: >> One last one, then I will crawl back into my hole. > > By the way, based on who I recall making a lot of comments, I'm > planning > on just adding: > > Acked-by: Neil Brown > Reviewed-by: Chuck Lever > Reviewed-by: Greg Banks > > to all of the server transport-switch and rdma patches. Does that > sound > right? OK for the transport switch. I'm not qualified to review the bulk of the RDMA work, so I would prefer that you don't add Reviewed-by "me" for those patches. My eyes glazed over a few lines after the GPL boilerplate. > And I'm assuming there are no objections to submitting this come the > next merge window. Refactoring the server-side write space logic has exposed some problems that really shouldn't be allowed to stand. I think we should resolve the issues in the TCP write space callback before merging. Realistically those problems are non-architectural and should be fixable before the window opens. -- Chuck Lever chuck[dot]lever[at]oracle[dot]com