From: "J. Bruce Fields" Subject: Re: [PATCH 020/100] nfsd: select CONFIG_PROC_FS in nfsv4 and gss server cases Date: Mon, 28 Jan 2008 16:48:51 -0500 Message-ID: <20080128214851.GO16785@fieldses.org> References: <1201303040-7779-14-git-send-email-bfields@citi.umich.edu> <1201303040-7779-15-git-send-email-bfields@citi.umich.edu> <1201303040-7779-16-git-send-email-bfields@citi.umich.edu> <120!1303040-7779-17-git-send-email-bfields@citi.umich.edu> <1201303040-7779-18-git-send-email-bfields@citi.umich.edu> <1201303040-7779-19-git-send-email-bfields@citi.umich.edu> <1201303040-7779-20-git-send-email-bfields@citi.umich.edu> <20080128182858.GC16785@fieldses.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-nfs@vger.kernel.org To: Chuck Lever Return-path: Received: from mail.fieldses.org ([66.93.2.214]:58715 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762462AbYA1Vsw (ORCPT ); Mon, 28 Jan 2008 16:48:52 -0500 In-Reply-To: Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, Jan 28, 2008 at 04:12:26PM -0500, Chuck Lever wrote: > On Jan 28, 2008, at 1:28 PM, J. Bruce Fields wrote: >> I don't care either way, but I'm inclined to leave this as is until >> someone comes along with really clear and convincing criteria for when >> to choose select and when to choose depends. > > If NFSv4 or GSS *require* procfs to work, then "depends" is the right > choice. Neither CONFIG_NFS_FS nor CONFIG_NFSD_FS seem to be following this rule? Could you submit a patch that fixes all of those? > > As the patch stands, selecting NFSv4 will also select PROC_FS, but you > can go back and deselect PROC_FS later; and you're back in the same boat > you were in before this patch. I just checked, and "make menuconfig", at least, isn't letting me go back and deselect PROC_FS. --b.