From: "J. Bruce Fields" Subject: Re: [PATCH] [NFSD] Typo in nfsd_vers() Date: Thu, 17 Jan 2008 09:33:42 -0500 Message-ID: <20080117143341.GA16581@fieldses.org> References: <478F472F.9050800@RedHat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-nfs@vger.kernel.org To: Steve Dickson Return-path: Received: from mail.fieldses.org ([66.93.2.214]:35386 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752948AbYAQOdn (ORCPT ); Thu, 17 Jan 2008 09:33:43 -0500 In-Reply-To: <478F472F.9050800-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Thu, Jan 17, 2008 at 07:16:47AM -0500, Steve Dickson wrote: > During my travels I found a small typo in nfsd_vers() (the routine > used by rpc.nfsd to set the protocol version(s) in NFS server) > > When testing to see which versions are available, nfsd_vers() should > use nfsd_versions[] not nfsd_version[]. The reason this typo is > not noticeable is due to the fact this availability info is used in > a reply that rpc.nfsd ignores. Thanks, applied! Your mailer's messing up the whitespace, though--might want to fix that for next time. --b. > > steved. > > > Author: Steve Dickson > Date: Thu Jan 17 06:50:57 2008 -0500 > > In nfsd_vers() the NFSD_AVAIL command should be using nfsd_versions[] > not nfsd_version[] > > Signed-off-by: Steve Dickson > > diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c > index 1190aea..f0c66e0 100644 > --- a/fs/nfsd/nfssvc.c > +++ b/fs/nfsd/nfssvc.c > @@ -134,7 +134,7 @@ int nfsd_vers(int vers, enum vers_op change) > case NFSD_TEST: > return nfsd_versions[vers] != NULL; > case NFSD_AVAIL: > - return nfsd_version[vers] != NULL; > + return nfsd_versions[vers] != NULL; > } > return 0; > }