From: James Lentini Subject: Re: [PATCH] SUNRPC xptrdma: simplify build configuration Date: Mon, 4 Feb 2008 09:45:00 -0500 (EST) Message-ID: References: <20080129001400.GZ16785@fieldses.org> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Tom Tucker , Thomas Talpey , Chuck Lever , linux-nfs@vger.kernel.org, nfs@lists.sourceforge.net To: Trond Myklebust , "J. Bruce Fields" Return-path: Received: from mx2.netapp.com ([216.240.18.37]:39882 "EHLO mx2.netapp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751394AbYBDOpW (ORCPT ); Mon, 4 Feb 2008 09:45:22 -0500 In-Reply-To: <20080129001400.GZ16785@fieldses.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Mon, 28 Jan 2008, J. Bruce Fields wrote: > On Mon, Jan 28, 2008 at 12:09:28PM -0500, James Lentini wrote: > > > > Trond and Bruce, > > > > This is a patch for 2.6.25. This is the same version that was sent out > > on December 12 for review (no comments to date). > > > > To simplify the RPC/RDMA client and server build configuration, make > > SUNRPC_XPRT_RDMA a hidden config option that continues to depend on > > SUNRPC and INFINIBAND. The value of SUNRPC_XPRT_RDMA will be: > > > > - N if either SUNRPC or INFINIBAND are N > > - M if both SUNRPC and INFINIBAND are on (M or Y) and at least one is M > > - Y if both SUNRPC and INFINIBAND are Y > > > > In 2.6.25, all of the RPC/RDMA related files are grouped in > > net/sunrpc/xprtrdma and the net/sunrpc/xprtrdma/Makefile builds both > > the client and server RPC/RDMA support using this config option. > > Makes sense to me. (Trond? Could you apply this or do you want me to?) Will this be sent up for 2.6.25? > > Signed-off-by: James Lentini > > > > Kconfig | 7 ++----- > > 1 file changed, 2 insertions(+), 5 deletions(-) > > > > --- a/fs/Kconfig > > +++ b/fs/Kconfig > > @@ -1782,12 +1782,9 @@ > > tristate > > > > config SUNRPC_XPRT_RDMA > > - tristate "RDMA transport for sunrpc (EXPERIMENTAL)" > > + tristate > > depends on SUNRPC && INFINIBAND && EXPERIMENTAL > > - default m > > - help > > - Adds a client RPC transport for supporting kernel NFS over RDMA > > - mounts, including Infiniband and iWARP. Experimental. > > + default SUNRPC && INFINIBAND > > > > config SUNRPC_BIND34 > > bool "Support for rpcbind versions 3 & 4 (EXPERIMENTAL)"