From: Chuck Lever Subject: [PATCH 5/5] NFS: NFS_V4 and NFSD_V4 should depend on SUNRPC_GSS Date: Fri, 14 Mar 2008 14:15:25 -0400 Message-ID: <20080314181525.29889.35370.stgit@manray.1015granger.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Cc: linux-nfs@vger.kernel.org To: Trond.Myklebust@netapp.com Return-path: Received: from flpi185.sbcis.sbc.com ([207.115.20.187]:41273 "EHLO flpi185.prodigy.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbYCNSPm (ORCPT ); Fri, 14 Mar 2008 14:15:42 -0400 Sender: linux-nfs-owner@vger.kernel.org List-ID: There is a guideline in Documentation/kbuild/kconfig-language.txt that states "In general use select only for non-visible symbols (no prompts anywhere) and for symbols with no dependencies." Both CONFIG_NFS_V4 and CONFIG_NFSD_V4 select RPCSEC_GSS_KRB5, which is visible, and has dependencies. For the sake of addressing the kconfig-language recommendation, "select RPCSEC_GSS_KRB5" to "select SUNRPC_GSS". The server side requires it to build properly, and the client side has it to provide support for loading GSS capabilities, which RFC 3530 makes mandatory for NFS version 4. Signed-off-by: Chuck Lever --- fs/Kconfig | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/Kconfig b/fs/Kconfig index bbc8e52..28b7ba5 100644 --- a/fs/Kconfig +++ b/fs/Kconfig @@ -1628,7 +1628,7 @@ config NFS_V3_ACL config NFS_V4 bool "NFS client support for NFS version 4 (EXPERIMENTAL)" depends on NFS_FS && EXPERIMENTAL - select RPCSEC_GSS_KRB5 + select SUNRPC_GSS help This option enables support for version 4 of the NFS protocol (RFC 3530) in the kernel's NFS client. @@ -1719,7 +1719,7 @@ config NFSD_V4 bool "NFS server support for NFS version 4 (EXPERIMENTAL)" depends on NFSD && PROC_FS && EXPERIMENTAL select NFSD_V3 - select RPCSEC_GSS_KRB5 + select SUNRPC_GSS help This option enables support in your system's NFS server for version 4 of the NFS protocol (RFC 3530).